Remove collector package

[lilic]

What this PR does / why we need it:

Initially, this started because we noticed, while using kube-state-metrics as a library, that there is an unnecessary pointer to an interface. Wanted to remove that pointer, but noticed that the collector package does not need to exist, as it's just a wrapper around store and instead we can just do a call .WriteAll(w) on the store object directly.

The majority of this PR is renaming things from collector -> store.

Note: None of the user-facing code was changed, as that would be a breaking change. So logs, flags that mention collectors stay unchanged. IMHO user-facing "collectors" flag should be renamed to "resources", but like I said that would be a user breaking change.

[brancz]

Are any of the vendoring changes necessary? It seems like if those are just updated, then we should do that in a separate PR.

Overall looks good. Happy to get rid of that effectively unused package.

[brancz]

Any way we can preserve the history of this one? it's really just a rename right?

[lilic]

It's not just a file rename, it also renames the individual build functions to Store suffix, e.g. buildDaemonSetCollection -> buildDaemonSetStore

guthub is bad at displaying the diff, but I split it multiple commits, so hopefully, it's easier. :)

[brancz]

Ah I see. In that case the diff is probably too large for git to acknowledge, that this might be a rename, so it would have had to happen in two commits. In that case I'm ok with it as is.

[lilic]

Are any of the vendoring changes necessary? It seems like if those are just updated, then we should do that in a separate PR.

I was wondering this as well when I noticed the big diff of added files. I think I ran the go mod vendor in case any of the deps in the collector package were removed, but seems like that triggered this update. Will remove this locally and test.

[lilic]

@brancz Update: the changes in the vendor directly are the result of running go mod vendor, as there is a check for that in validate-modules target, hence the change to the vendor dir.

[brancz]

Interesting. In that case this lgtm. Thanks!

/lgtm

[k8s-ci-robot]

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: brancz, LiliC

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

• OWNERS [brancz]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

[lilic]

Travis seems to be having some issues with starting the build. 🤷‍♀