-
Notifications
You must be signed in to change notification settings - Fork 1.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Namespace status conditions #949
Namespace status conditions #949
Conversation
Thanks @wozniakjan! I've also created this issue on the autoscaler repository - kubernetes/autoscaler#2447 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for your PR. Do you mind also adding this to the docs, thanks!
1abe1ce
to
5fea197
Compare
9e5bd83
to
e29f112
Compare
e29f112
to
7a75a4a
Compare
@tariq1890, @brennerm the VPA has now updated the deps kubernetes/autoscaler#2486 In 7a75a4a I tried to update the go modules with updated VPA. This was the smallest set of changes allowed me to build the kube-state-metrics, any hints and pointers on how to make it even smaller so I don't pollute the |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This is looking good to me, are we ready to move forward with this PR?
cc @tariq1890 to re-review as well
- k8s.io/apimachinery to v1.16.2 - k8s.io/klog to v1.0.0 - k8s.io/autoscaler to current master
7a75a4a
to
4ffe41f
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
/lgtm
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: tariq1890, wozniakjan The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
@wozniakjan Thank you so much for your hard work with this! You are awesome :). |
Thanks for valuable feedback and reviewing this to successful merge, always happy to help :) |
What this PR does / why we need it:
Add metrics for namespace status conditions - kubernetes/community#4045, kubernetes/kubernetes#73405
NOTE: this requires kubernetes v1.16 among dependencies. There is a tracker which updates the dependencies #945 and this PR should wait and rebase when #945 merges. As a makeshift solution for testing, this uses fork of autoscaler https://github.com/wozniakjan/autoscaler with swapped7a75a4a contains the dependency update mentioned in #945go dep
togo mod
and includes necessary changes to bring kubernetes v1.16.1 as a dependency. I will try to upstream the changes to autoscaler to unblock dependency mismatch.Sample output: