Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

add hpa stats for current utilization and average value #961

Merged
merged 1 commit into from
Nov 4, 2019
Merged

add hpa stats for current utilization and average value #961

merged 1 commit into from
Nov 4, 2019

Conversation

ashleycutalo
Copy link
Contributor

What this PR does / why we need it:
When debugging issues such as kubernetes/kubernetes#82195, it was necessary to export these stats in order to understand what the hpa sees at the time of the overflow and other such bugs.

Which issue(s) this PR fixes (optional, in fixes #<issue number>(, fixes #<issue_number>, ...) format, will close the issue(s) when PR gets merged):
Fixes #

@k8s-ci-robot k8s-ci-robot added the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label Oct 29, 2019
@k8s-ci-robot
Copy link
Contributor

Welcome @ashleykasim!

It looks like this is your first PR to kubernetes/kube-state-metrics 🎉. Please refer to our pull request process documentation to help your PR have a smooth ride to approval.

You will be prompted by a bot to use commands during the review process. Do not be afraid to follow the prompts! It is okay to experiment. Here is the bot commands documentation.

You can also check if kubernetes/kube-state-metrics has its own contribution guidelines.

You may want to refer to our testing guide if you run into trouble with your tests not passing.

If you are having difficulty getting your pull request seen, please follow the recommended escalation practices. Also, for tips and tricks in the contribution process you may want to read the Kubernetes contributor cheat sheet. We want to make sure your contribution gets all the attention it needs!

Thank you, and welcome to Kubernetes. 😃

@k8s-ci-robot k8s-ci-robot added cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. size/M Denotes a PR that changes 30-99 lines, ignoring generated files. labels Oct 29, 2019
@k8s-ci-robot k8s-ci-robot added size/L Denotes a PR that changes 100-499 lines, ignoring generated files. and removed needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. size/M Denotes a PR that changes 30-99 lines, ignoring generated files. labels Oct 29, 2019
@ashleycutalo ashleycutalo force-pushed the hpa-metrics branch 3 times, most recently from 059157c to f16bd59 Compare October 29, 2019 21:11
@ashleycutalo
Copy link
Contributor Author

/assign @lilic

tariq1890
tariq1890 reviewed Oct 29, 2019
View reviewed changes
internal/store/hpa.go Outdated Show resolved Hide resolved
tariq1890
tariq1890 reviewed Oct 30, 2019
View reviewed changes
internal/store/hpa.go Outdated Show resolved Hide resolved
tariq1890
tariq1890 reviewed Oct 30, 2019
View reviewed changes
internal/store/hpa.go Outdated Show resolved Hide resolved
@tariq1890
Copy link
Contributor

tariq1890 commented Oct 30, 2019 •
edited
Loading

Thanks for your PR @ashleykasim. I've provided my comments. Will wait on @lilic for her comments as well.

lilic
lilic reviewed Oct 30, 2019
View reviewed changes
Copy link
Member

@lilic lilic left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Few comments, after those are addressed and @tariq1890 ones, this is good to go. Thanks for the PR!

internal/store/hpa.go Show resolved Hide resolved
internal/store/hpa.go Outdated Show resolved Hide resolved
internal/store/hpa.go Outdated Show resolved Hide resolved
@k8s-ci-robot k8s-ci-robot added size/M Denotes a PR that changes 30-99 lines, ignoring generated files. and removed size/L Denotes a PR that changes 100-499 lines, ignoring generated files. labels Oct 30, 2019
tariq1890
tariq1890 reviewed Oct 30, 2019
View reviewed changes
internal/store/hpa.go Outdated Show resolved Hide resolved
tariq1890
tariq1890 reviewed Oct 30, 2019
View reviewed changes
internal/store/hpa.go Outdated Show resolved Hide resolved
tariq1890
tariq1890 reviewed Oct 30, 2019
View reviewed changes
internal/store/hpa.go Outdated Show resolved Hide resolved
@brancz brancz mentioned this pull request Oct 31, 2019
Closed
@k8s-ci-robot k8s-ci-robot added size/L Denotes a PR that changes 100-499 lines, ignoring generated files. and removed size/M Denotes a PR that changes 30-99 lines, ignoring generated files. labels Nov 4, 2019
@lilic
Copy link
Member

lilic commented Nov 4, 2019

@ashleykasim is this ready for another review?

@ashleycutalo
Copy link
Contributor Author

@lilic Yes please!

tariq1890
tariq1890 reviewed Nov 4, 2019
View reviewed changes
internal/store/hpa.go Outdated Show resolved Hide resolved
tariq1890
tariq1890 reviewed Nov 4, 2019
View reviewed changes
internal/store/hpa.go Outdated Show resolved Hide resolved
tariq1890
tariq1890 approved these changes Nov 4, 2019
View reviewed changes
Copy link
Contributor

@tariq1890 tariq1890 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

Thank you for your contribution @ashleykasim :).

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Nov 4, 2019
@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: ashleykasim, tariq1890

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Nov 4, 2019
@k8s-ci-robot k8s-ci-robot merged commit e51fc8f into kubernetes:master Nov 4, 2019
@lilic
Copy link
Member

lilic commented Nov 5, 2019

Thanks for the contribution! 🎉

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@lilic lilic lilic left review comments

@tariq1890 tariq1890 tariq1890 approved these changes

@zouyee zouyee Awaiting requested review from zouyee

Assignees

@tariq1890 tariq1890

@lilic lilic

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. lgtm "Looks good to me", indicates that a PR is ready to be merged. size/L Denotes a PR that changes 100-499 lines, ignoring generated files.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@ashleycutalo @k8s-ci-robot @tariq1890 @lilic