Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add kube-state-metrics own alerting rules #962

Merged
merged 3 commits into from
Dec 5, 2019
Merged

Add kube-state-metrics own alerting rules #962

merged 3 commits into from
Dec 5, 2019

Conversation

lilic
Copy link
Member

@lilic lilic commented Oct 30, 2019

This PR introduces a kube-state-metrics mixin and adds generated KubeStateMetricsListErrors and KubeStateMetricsWatchErrors.

I guess we should add some docs as well, should these live in the main README?

cc @tariq1890 @brancz @metalmatze

@k8s-ci-robot k8s-ci-robot added cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. size/L Denotes a PR that changes 100-499 lines, ignoring generated files. labels Oct 30, 2019
@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Oct 30, 2019
@k8s-ci-robot k8s-ci-robot added size/XXL Denotes a PR that changes 1000+ lines, ignoring generated files. and removed size/L Denotes a PR that changes 100-499 lines, ignoring generated files. labels Oct 31, 2019
@k8s-ci-robot k8s-ci-robot added size/L Denotes a PR that changes 100-499 lines, ignoring generated files. and removed size/XXL Denotes a PR that changes 1000+ lines, ignoring generated files. labels Oct 31, 2019
@lilic
Copy link
Member Author

lilic commented Oct 31, 2019

Done, PTAL @brancz

tariq1890
tariq1890 reviewed Nov 4, 2019
View reviewed changes
Makefile Outdated Show resolved Hide resolved
@k8s-ci-robot k8s-ci-robot added size/XXL Denotes a PR that changes 1000+ lines, ignoring generated files. and removed size/L Denotes a PR that changes 100-499 lines, ignoring generated files. labels Nov 4, 2019
tariq1890
tariq1890 reviewed Nov 4, 2019
View reviewed changes
go.mod Outdated Show resolved Hide resolved
tariq1890
tariq1890 reviewed Nov 4, 2019
View reviewed changes
Makefile Outdated Show resolved Hide resolved
tariq1890
tariq1890 reviewed Nov 4, 2019
View reviewed changes
Makefile Outdated Show resolved Hide resolved
@k8s-ci-robot k8s-ci-robot added size/L Denotes a PR that changes 100-499 lines, ignoring generated files. and removed size/XXL Denotes a PR that changes 1000+ lines, ignoring generated files. labels Nov 15, 2019
@lilic lilic force-pushed the add-mixin branch 2 times, most recently from ad4da09 to 502b944 Compare November 16, 2019 00:11
@lilic lilic changed the title Add kube-state-metrics own alerting rules WIP: Add kube-state-metrics own alerting rules Nov 16, 2019
@k8s-ci-robot k8s-ci-robot added the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Nov 16, 2019
@lilic lilic changed the title WIP: Add kube-state-metrics own alerting rules Add kube-state-metrics own alerting rules Nov 19, 2019
@k8s-ci-robot k8s-ci-robot removed the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Nov 19, 2019
@lilic
Copy link
Member Author

lilic commented Nov 19, 2019

@tariq1890 @brancz this is ready for review, thanks!

@k8s-ci-robot k8s-ci-robot added the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label Dec 5, 2019
@k8s-ci-robot k8s-ci-robot removed the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label Dec 5, 2019
@lilic
Copy link
Member Author

lilic commented Dec 5, 2019

Done, PTAL @tariq1890 @brancz thanks!

tariq1890
tariq1890 approved these changes Dec 5, 2019
View reviewed changes
Copy link
Contributor

@tariq1890 tariq1890 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

Thanks for this @lilic!

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Dec 5, 2019
@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: LiliC, tariq1890

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot merged commit 881434e into kubernetes:master Dec 5, 2019
@lilic
Copy link
Member Author

lilic commented Dec 5, 2019

Is is possible to include this in the release when you cut the branch @tariq1890

@lilic lilic deleted the add-mixin branch December 5, 2019 06:07
tariq1890 added a commit to tariq1890/kube-state-metrics that referenced this pull request Dec 5, 2019
@tariq1890
add PR kubernetes#962 to the v1.9.0-rc.0 CHANGELOG
e3bed33
tariq1890 added a commit to tariq1890/kube-state-metrics that referenced this pull request Dec 9, 2019
@tariq1890
add PR kubernetes#962 to the v1.9.0-rc.0 CHANGELOG
3b992c8
k8s-ci-robot added a commit that referenced this pull request Dec 9, 2019
@k8s-ci-robot
Merge pull request #994 from tariq1890/urelease-1.9
11db1d4 
Add PR #962 to the v1.9.0-rc.0 CHANGELOG
lilic pushed a commit to lilic/kube-state-metrics that referenced this pull request Dec 20, 2019
@tariq1890 @lilic
add PR kubernetes#962 to the v1.9.0-rc.0 CHANGELOG
25b6c2c
lilic pushed a commit to lilic/kube-state-metrics that referenced this pull request Dec 20, 2019
@tariq1890 @lilic
add PR kubernetes#962 to the v1.9.0-rc.0 CHANGELOG
f23ee61
lilic pushed a commit to lilic/kube-state-metrics that referenced this pull request Dec 20, 2019
@tariq1890 @lilic
add PR kubernetes#962 to the v1.9.0-rc.0 CHANGELOG
600f4e5
lilic pushed a commit to lilic/kube-state-metrics that referenced this pull request Dec 20, 2019
@tariq1890 @lilic
add PR kubernetes#962 to the v1.9.0-rc.0 CHANGELOG
65c6f84
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@brancz brancz brancz left review comments

@tariq1890 tariq1890 tariq1890 approved these changes

@zouyee zouyee Awaiting requested review from zouyee

Assignees

@tariq1890 tariq1890

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. lgtm "Looks good to me", indicates that a PR is ready to be merged. size/L Denotes a PR that changes 100-499 lines, ignoring generated files.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@lilic @k8s-ci-robot @tariq1890 @brancz