-
Notifications
You must be signed in to change notification settings - Fork 2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Added a kube_hpa_target_metric metric that publishes all of a HPA's target metrics. #966
Conversation
Welcome @janzantinge! |
c195e7b
to
12042d2
Compare
/assign @tariq1890 |
32e4797
to
ed9eaaa
Compare
Is there anything you all need from me to get this PR reviewed? Just more time? |
Very sorry for the delay @janzantinge ! I've provided my review comments. |
ed9eaaa
to
a0c63d5
Compare
12718da
to
4544701
Compare
(value, average, and utilization).
4544701
to
cef3bab
Compare
/lgtm Thank you so much for your contribution @janzantinge ! Sorry once again for the delay :) |
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: janzantinge, tariq1890 The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
What this PR does / why we need it:
kube-state-metrics currently publishes only part of a Horizontal Pod Autoscaler's spec, specifically the Minimum and Maximum Replicas values. This PR aims to add the HPA's target metric values to the list metrics to be published.
Which issue(s) this PR fixes
Fixes #768