Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Added a kube_hpa_target_metric metric that publishes all of a HPA's target metrics. #966

Merged
merged 2 commits into from
Nov 14, 2019
Merged

Added a kube_hpa_target_metric metric that publishes all of a HPA's target metrics. #966

merged 2 commits into from
Nov 14, 2019

Conversation

janzantinge
Copy link
Contributor

What this PR does / why we need it:
kube-state-metrics currently publishes only part of a Horizontal Pod Autoscaler's spec, specifically the Minimum and Maximum Replicas values. This PR aims to add the HPA's target metric values to the list metrics to be published.

Which issue(s) this PR fixes
Fixes #768

@k8s-ci-robot k8s-ci-robot added the cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. label Nov 1, 2019
@k8s-ci-robot
Copy link
Contributor

Welcome @janzantinge!

It looks like this is your first PR to kubernetes/kube-state-metrics 🎉. Please refer to our pull request process documentation to help your PR have a smooth ride to approval.

You will be prompted by a bot to use commands during the review process. Do not be afraid to follow the prompts! It is okay to experiment. Here is the bot commands documentation.

You can also check if kubernetes/kube-state-metrics has its own contribution guidelines.

You may want to refer to our testing guide if you run into trouble with your tests not passing.

If you are having difficulty getting your pull request seen, please follow the recommended escalation practices. Also, for tips and tricks in the contribution process you may want to read the Kubernetes contributor cheat sheet. We want to make sure your contribution gets all the attention it needs!

Thank you, and welcome to Kubernetes. 😃

@k8s-ci-robot k8s-ci-robot added the size/L Denotes a PR that changes 100-499 lines, ignoring generated files. label Nov 1, 2019
@janzantinge
Copy link
Contributor Author

/assign @tariq1890

@janzantinge janzantinge force-pushed the hpa_spec_targets branch 2 times, most recently from 32e4797 to ed9eaaa Compare November 7, 2019 14:50
@janzantinge
Copy link
Contributor Author

Is there anything you all need from me to get this PR reviewed? Just more time?

tariq1890
tariq1890 reviewed Nov 14, 2019
View reviewed changes
internal/store/hpa.go Outdated Show resolved Hide resolved
@tariq1890
Copy link
Contributor

Very sorry for the delay @janzantinge ! I've provided my review comments.

tariq1890
tariq1890 reviewed Nov 14, 2019
View reviewed changes
internal/store/hpa.go Outdated Show resolved Hide resolved
janzantinge
janzantinge commented Nov 14, 2019
View reviewed changes
internal/store/hpa.go Outdated Show resolved Hide resolved
tariq1890
tariq1890 reviewed Nov 14, 2019
View reviewed changes
internal/store/hpa.go Outdated Show resolved Hide resolved
tariq1890
tariq1890 reviewed Nov 14, 2019
View reviewed changes
internal/store/hpa.go Outdated Show resolved Hide resolved
@tariq1890
Copy link
Contributor

/lgtm
/approve

Thank you so much for your contribution @janzantinge ! Sorry once again for the delay :)

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Nov 14, 2019
@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: janzantinge, tariq1890

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Nov 14, 2019
@k8s-ci-robot k8s-ci-robot merged commit 7b5ea84 into kubernetes:master Nov 14, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@tariq1890 tariq1890 tariq1890 approved these changes

@lilic lilic Awaiting requested review from lilic

@zouyee zouyee Awaiting requested review from zouyee

Assignees

@tariq1890 tariq1890

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. lgtm "Looks good to me", indicates that a PR is ready to be merged. size/L Denotes a PR that changes 100-499 lines, ignoring generated files.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Add target and current cpu utilization in hpa metrics
3 participants
@janzantinge @k8s-ci-robot @tariq1890