Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Install conntrack as a deb/rpm dep? #1287

Closed
luxas opened this issue Nov 28, 2018 · 8 comments · Fixed by kubernetes/kubernetes#71540
Closed

Install conntrack as a deb/rpm dep? #1287

luxas opened this issue Nov 28, 2018 · 8 comments · Fixed by kubernetes/kubernetes#71540
Labels
help wanted Denotes an issue that needs help from a contributor. Must meet "help wanted" guidelines. lifecycle/active Indicates that an issue or PR is actively being worked on by a contributor. priority/backlog Higher priority than priority/awaiting-more-evidence.
Milestone
v1.14

Comments

@luxas
Copy link
Member

luxas commented Nov 28, 2018

From kubelet logs in a fresh v1.13.0-rc.1 install:

Nov 28 12:40:01 kubeadm-test kubelet[12151]: W1128 12:40:01.147255   12151 hostport_manager.go:68] The binary conntrack is not installed, this can cause failures in network connection cleanup.
@luxas luxas added help wanted Denotes an issue that needs help from a contributor. Must meet "help wanted" guidelines. priority/backlog Higher priority than priority/awaiting-more-evidence. labels Nov 28, 2018
@luxas luxas added this to the v1.14 milestone Nov 28, 2018
@mauilion
Copy link

/assign

@k8s-ci-robot
Copy link
Contributor

@mauilion: GitHub didn't allow me to assign the following users: mauilion.

Note that only kubernetes members and repo collaborators can be assigned.
For more information please see the contributor guide

In response to this:

/assign

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@mauilion
Copy link

I am interested in taking this on.

@luxas
Copy link
Member Author

luxas commented Nov 28, 2018

Thanks @mauilion! Making sure conntrack is a dep of (all!) our packages is necessary for this.
For context, can you also research why it's needed etc. please

@luxas luxas added the lifecycle/active Indicates that an issue or PR is actively being worked on by a contributor. label Nov 28, 2018
@mauilion
Copy link

mauilion commented Nov 28, 2018 •
edited

@luxas I am looking at doing this work in k8s.io/release there is also a set of files in k8s.io/kubernetes/build/ should I update both or just the release side?

Also per your comment shall I update kube{adm,let} with this dependency? The container images likely already grab conntrack.

@dims
Copy link
Member

dims commented Nov 28, 2018

@mauilion we need to keep both in sync for the time being. yes please

mauilion pushed a commit to mauilion/release that referenced this issue Nov 29, 2018
Add conntrack as dependency for kube{adm,let}
c6ab728 
Addresses kubernetes/kubeadm#1287

Also associated with a PR in the k8s.io/kubernetes to keep the changes
in sync.

Signed-off-by: Duffie Cooley <dcooley@heptio.com>
mauilion pushed a commit to mauilion/release that referenced this issue Nov 29, 2018
Add conntrack as dependency for kube{adm,let}
a568f49 
Addresses kubernetes/kubeadm#1287

Also associated with a PR in the k8s.io/kubernetes to keep the changes
in sync.

/cc @luxas @dims

Signed-off-by: Duffie Cooley <dcooley@heptio.com>
This was referenced Nov 29, 2018
Merged
Merged
mauilion pushed a commit to mauilion/release that referenced this issue Nov 29, 2018
Add conntrack as dependency for kube{adm,let}
47ac206 
Addresses kubernetes/kubeadm#1287

Also associated with a PR in the k8s.io/kubernetes to keep the changes
in sync.

Signed-off-by: Duffie Cooley <dcooley@heptio.com>
mauilion pushed a commit to mauilion/release that referenced this issue Nov 29, 2018
Add conntrack as dependency for kubelet
932d554 
Addresses kubernetes/kubeadm#1287

Also associated with a PR in the k8s.io/kubernetes to keep the changes
in sync.

This change adds conntrack as a dependency for kubelet when building
rpms or debs.

Signed-off-by: Duffie Cooley <dcooley@heptio.com>
@luxas
Copy link
Member Author

luxas commented Dec 4, 2018

Reopening to track kubernetes/release#653

@luxas luxas reopened this Dec 4, 2018
@luxas luxas reopened this Dec 8, 2018
@neolit123
Copy link
Member

seems that kubernetes/release#653 was merged.
please reopen again if needed.

justaugustus pushed a commit to justaugustus/release that referenced this issue Jun 10, 2019
Add conntrack as dependency for kubelet
9009cf6 
Addresses kubernetes/kubeadm#1287

Also associated with a PR in the k8s.io/kubernetes to keep the changes
in sync.

This change adds conntrack as a dependency for kubelet when building
rpms or debs.

Signed-off-by: Duffie Cooley <dcooley@heptio.com>
justaugustus pushed a commit to justaugustus/release that referenced this issue Jun 10, 2019
@justaugustus
Add conntrack as dependency for kubelet
7a4622d 
Addresses kubernetes/kubeadm#1287

Also associated with a PR in the k8s.io/kubernetes to keep the changes
in sync.

This change adds conntrack as a dependency for kubelet when building
rpms or debs.

Signed-off-by: Duffie Cooley <dcooley@heptio.com>
@pohly pohly mentioned this issue Dec 3, 2019
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
help wanted Denotes an issue that needs help from a contributor. Must meet "help wanted" guidelines. lifecycle/active Indicates that an issue or PR is actively being worked on by a contributor. priority/backlog Higher priority than priority/awaiting-more-evidence.
Projects
None yet
Milestone
v1.14
Development

Successfully merging a pull request may close this issue.

Add conntrack as a dependency of kubelet mauilion/kubernetes
5 participants
@dims @neolit123 @mauilion @luxas @k8s-ci-robot