New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Rename RunPullImagesCheck to CheckAndRunPulllImages #1352
Comments
/assign MalloZup |
if you have another name suggestion feel free to suggest |
@MalloZup I can look into it. |
@neolit123 we can sync in slack for issue prios.o me I felt that it was a follow-up for later. I agree it isn't high pro |
@rosti for me should be valid to rename it because isn't much implicit by the name that we are also pulling the images. However if we rename this function, also the other name of function might be in the same situation. I had just a look. Anyways, i'm ok with both decision, to rename or not. tia 🚀 |
@neolit123 sure, please assign some high priority items for me in todays kubeadm office hours. |
@neolit123 my view on this one is that the rename is necessary. The func is named that way for historical reasons that are no longer true. Hence the change is necessary, but not at all urgent. |
/priority backlog |
@RA489 |
Ok, this is a bit more complex than just a rename:
@RA489 I'll be happy to do a review of a PR about this, but this is a backlog and "not current milestone" issue, also it's not a very trivial to do, so I'll recommend jumping off to something more important in the current milestone. |
This issue is a follow-up from kubernetes/kubernetes#72870
i will tackle this once that pr is merged.
Problem was that the name of function can lead confusion. We should make more explicit that we also pulluing image really and not run only checks as the name could suggest
The text was updated successfully, but these errors were encountered: