Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

make the etcd client retry logic consistent #2181

Closed
neolit123 opened this issue Jun 11, 2020 · 1 comment · Fixed by kubernetes/kubernetes#92131
Closed

make the etcd client retry logic consistent #2181

neolit123 opened this issue Jun 11, 2020 · 1 comment · Fixed by kubernetes/kubernetes#92131
Assignees
@SataQiu
Labels
area/etcd help wanted Denotes an issue that needs help from a contributor. Must meet "help wanted" guidelines. kind/cleanup Categorizes issue or PR as related to cleaning up code, process, or technical debt. lifecycle/active Indicates that an issue or PR is actively being worked on by a contributor. priority/important-longterm Important over the long term, but may not be staffed and/or may need multiple releases to complete.
Milestone
v1.19

Comments

@neolit123
Copy link
Member

after this merged:
kubernetes/kubernetes#90645

we made the MemberAdd retry logic a bit different in terms of retries.

  • make etcd client logic consistent for all methods, by wrapping both client dial and client operation
  • use the same timeouts / exp-backoff everywhere.

/priority important-longterm
/kind cleanup
@k8s-ci-robot k8s-ci-robot added priority/important-longterm Important over the long term, but may not be staffed and/or may need multiple releases to complete. kind/cleanup Categorizes issue or PR as related to cleaning up code, process, or technical debt. labels Jun 11, 2020
@neolit123 neolit123 added area/etcd help wanted Denotes an issue that needs help from a contributor. Must meet "help wanted" guidelines. labels Jun 11, 2020
@neolit123 neolit123 added this to the v1.20 milestone Jun 11, 2020
@neolit123 neolit123 changed the title make the etcd client logic consistent make the etcd client retry logic consistent Jun 11, 2020
@SataQiu
Copy link
Member

SataQiu commented Jun 15, 2020

/assign

@SataQiu SataQiu mentioned this issue Jun 15, 2020
Merged
@neolit123 neolit123 modified the milestones: v1.20, v1.19 Jun 16, 2020
@neolit123 neolit123 added the lifecycle/active Indicates that an issue or PR is actively being worked on by a contributor. label Jun 18, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@SataQiu SataQiu

Labels
area/etcd help wanted Denotes an issue that needs help from a contributor. Must meet "help wanted" guidelines. kind/cleanup Categorizes issue or PR as related to cleaning up code, process, or technical debt. lifecycle/active Indicates that an issue or PR is actively being worked on by a contributor. priority/important-longterm Important over the long term, but may not be staffed and/or may need multiple releases to complete.
Projects
None yet
Milestone
v1.19
Development

Successfully merging a pull request may close this issue.

kubeadm: increase robustness for kubeadm etcd operations SataQiu/kubernetes
3 participants
@neolit123 @SataQiu @k8s-ci-robot