-
Notifications
You must be signed in to change notification settings - Fork 39.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
kubeadm: increase robustness for kubeadm etcd operations #92131
Conversation
@SataQiu: The label(s) In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
/kind cleanup |
/priority important-soon |
/assign @neolit123 |
/retest |
cmd/kubeadm/app/util/etcd/etcd.go
Outdated
var err error | ||
cli, err = clientv3.New(clientv3.Config{ | ||
Endpoints: c.Endpoints, | ||
DialTimeout: dialTimeout, |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
for MemberAdd we made this equal to etcdTimeout
, which means that we can potentially remove the dialTimeout
var.
is concerning, but maybe our new retries scheme would be beneficial for the arm64 issue too.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
+1 let's do it.
If there's a problem, we can revert it back.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
thanks @SataQiu .
added one comment to make the dial timeout consistent too.
/assign @fabriziopandini
Signed-off-by: SataQiu <1527062125@qq.com>
64c70a7
to
800dd19
Compare
/lgtm |
/retest |
/test pull-kubernetes-node-e2e |
/cc @fabriziopandini |
/lgtm |
/approve |
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: neolit123, SataQiu The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
/test pull-kubernetes-integration |
/retest |
/retest Review the full test history for this PR. Silence the bot with an |
/retest |
/retest Review the full test history for this PR. Silence the bot with an |
2 similar comments
/retest Review the full test history for this PR. Silence the bot with an |
/retest Review the full test history for this PR. Silence the bot with an |
What type of PR is this?
/kind bug
/kind cleanup
What this PR does / why we need it:
make the etcd client retry logic consistent, increase robustness for kubeadm etcd operations.
Which issue(s) this PR fixes:
Fixes kubernetes/kubeadm#2181
Special notes for your reviewer:
Does this PR introduce a user-facing change?:
Additional documentation e.g., KEPs (Kubernetes Enhancement Proposals), usage docs, etc.: