-
Notifications
You must be signed in to change notification settings - Fork 703
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
kubeadm feature flags #22
Comments
From @lukemarsden on October 20, 2016 10:13 Thank you for this @bogdando! We definitely want to make |
From @bogdando on October 20, 2016 10:31 @lukemarsden thank you, I will |
From @bogdando on October 24, 2016 14:1 Also note that while being configurable is very nice to have, runtime flags must allow to specify which steps a user wants the |
From @bogdando on October 27, 2016 11:13 This is now tracked as kubernetes/enhancements#138 |
From @pires on October 27, 2016 16:16 Just to add to what Luke said, there's file configuration support for |
From @bogdando on October 28, 2016 14:4 Reopened as there is yet another optional place to track it |
@mikedanese |
@aisarmog That issue isn't handled here, please open a new one if you still have issues. |
@mikedanese thanks for working on this spec. Heads up! I still believe that feature flags should be runtime flags. And that's why: Taco Bell programming is known for using tones of flags for decades, and it just works. Config options suxx in containers world: you have to mount them as files/configmaps, take care of multiple RW access (data integrity), notifications of the main process on changes etc. (and I think that's why there is so much runtime flags in kubelet and so none as config options. So why not kubedam to follow kubelet design decisions?) |
Please update the "Related feature kubernetes/enhancements#11" the original description contains wrong link |
We are trying to be consistent by standardizing on file based config. We are migrating all components to file based config. kubernetes/kubernetes#12245 |
Kubelet and other components already do support file based config |
@wilkers-steve and @larryrensing; can you guys reach out to @mikedanese to find out how we can start getting involved and help with things like this? if there are any gaps, i'd like to work with the kubeadm team to close them. |
@v1k0d3n you got it |
This is implemented with |
From @bogdando on October 19, 2016 16:32
FEATURE REQUEST:
Add runtime/config feature flags for granular control of
kubeadm init
tasks. Like:Use case:
One may want to use hyperkube and do not pull images for apiserver and other components.
Or one may want to only run certs management tasks, or only re-generate configs or static manifests pods or only install addons. Having feature flags eases idempotent runs, co-existing with external CM systems like ansible or puppet and integration testing efforts a lot.
The feature flags, either CLI or config file based, should ease integration efforts and make the tool more flexible as well.
Related feature #11
Kubernetes version (use
kubectl version
): nextEnvironment:
uname -a
): anyCopied from original issue: kubernetes/kubernetes#35133
The text was updated successfully, but these errors were encountered: