Kubeadm: unit tests failed on server with multiple CRI endpoints

[haoruan]

Which jobs are failing?

unit test

Which tests are failing?

FAIL    k8s.io/kubernetes/cmd/kubeadm/app/cmd   72.245s
FAIL    k8s.io/kubernetes/cmd/kubeadm/app/cmd/upgrade   0.190s
FAIL    k8s.io/kubernetes/cmd/kubeadm/app/phases/upgrade        1.448s
FAIL    k8s.io/kubernetes/cmd/kubeadm/app/preflight     0.211s
FAIL    k8s.io/kubernetes/cmd/kubeadm/app/util/config

They all failed with same errors:

Found multiple CRI endpoints on the host. Please define which one do you wish to use by setting the 'criSocket' field in the kubeadm configuration file: unix:///var/run/containerd/containerd.sock, unix:///var/run/cri-dockerd.sock

Since when has it been failing?

Always

Testgrid link

No response

Reason for failure (if possible)

criSocket is required for InitConfiguration on server with multiple CRI endpoints, but in unit test criSocket is empty.

Anything else we need to know?

No response

Relevant SIG(s)

/area kubeadm

[k8s-ci-robot]

There are no sig labels on this issue. Please add an appropriate label by using one of the following commands:

• /sig <group-name>
• /wg <group-name>
• /committee <group-name>

Please see the group list for a listing of the SIGs, working groups, and committees available.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

[k8s-ci-robot]

This issue is currently awaiting triage.

If a SIG or subproject determines this is a relevant issue, they will accept it by applying the triage/accepted label and provide further guidance.

The triage/accepted label can be added by org members by writing /triage accepted in a comment.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

[neolit123]

/transfer kubeadm

[neolit123]

makes sense to fix this. thanks for logging the issue.
if someone wants to send a PR, please go ahead.

we need to pass a predefined CRI endpoint in an InitConfiguration.
IIRC, this can be used:
https://github.com/kubernetes/kubernetes/blob/master/cmd/kubeadm/app/constants/constants.go#L269

/help

[k8s-ci-robot]

@neolit123:
This request has been marked as needing help from a contributor.

Guidelines

Please ensure that the issue body includes answers to the following questions:

• Why are we solving this issue?
• To address this issue, are there any code changes? If there are code changes, what needs to be done in the code and what places can the assignee treat as reference points?
• Does this issue have zero to low barrier of entry?
• How can the assignee reach out to you for help?

For more details on the requirements of such an issue, please see here and ensure that they are met.

If this request no longer meets these requirements, the label can be removed
by commenting with the /remove-help command.

In response to this:

makes sense to fix this. thanks for logging the issue.
if someone wants to send a PR, please go ahead.

we need to pass a predefined CRI endpoint in an InitConfiguration.
IIRC, this can be used:
https://github.com/kubernetes/kubernetes/blob/master/cmd/kubeadm/app/constants/constants.go#L269

/help

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

[liangyuanpeng]

Seems like this issue can be closed.

/close

[k8s-ci-robot]

@liangyuanpeng: You can't close an active issue/PR unless you authored it or you are a collaborator.

In response to this:

Seems like this issue can be closed.

/close

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

[SataQiu]

Seems like this issue can be closed.

No, we still need to fix the remaining cases.

[chendave]

/assign

Let me take care of rest of them.