Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

graduate the flag for structural output --experimental-output to just --output #3045

Open
neolit123 opened this issue Apr 18, 2024 · 6 comments
Assignees
Labels
area/cli kind/deprecation Categorizes issue or PR as related to a feature/enhancement marked for deprecation. kind/feature Categorizes issue or PR as related to a new feature. priority/important-soon Must be staffed and worked on either currently, or very soon, ideally in time for the next release.
Milestone

Comments

@neolit123
Copy link
Member

noticed the flag is still experimental here:
kubernetes/website#45911

the feature of structural output in kubeadm has been active for a 5+ releases.
this implies the backend works. the API is still alpha, but it's not attached to the backend usage.
we can just graduate the output API in another iteration.

https://github.com/carlory/kubernetes/blob/227c2e7c2b2c05a9c8b2885460e28e4da25cf558/cmd/kubeadm/app/util/output/output.go#L102-L108

in 1.31:

  • mark --experimental-output as deprecated. add a new flag --output that also does the same thing
    TODO

in 1.32:

  • remove --experimental-output
    TODO
@neolit123 neolit123 added priority/important-soon Must be staffed and worked on either currently, or very soon, ideally in time for the next release. area/UX kind/feature Categorizes issue or PR as related to a new feature. labels Apr 18, 2024
@neolit123 neolit123 added this to the v1.31 milestone Apr 18, 2024
@neolit123
Copy link
Member Author

@carlory please say if you don't have the time to work on this.

@carlory
Copy link
Member

carlory commented Apr 18, 2024

@neolit123 I can do it 😊

@carlory
Copy link
Member

carlory commented Apr 18, 2024

but according to the KEP, some commands still need to be implemented. https://github.com/kubernetes/enhancements/tree/master/keps/sig-cluster-lifecycle/kubeadm/2504-kubeadm-machine-output#goals

@neolit123
Copy link
Member Author

neolit123 commented Apr 18, 2024

but according to the KEP, some commands still need to be implemented. https://github.com/kubernetes/enhancements/tree/master/keps/sig-cluster-lifecycle/kubeadm/2504-kubeadm-machine-output#goals

the KEP is out of date (i think0, but new commands can be added and still use --output.
we can prefix the description of --output for a particular command as EXPERIMENTAL

generally using --experimental-.... is a breaking change and not desired.

@neolit123 neolit123 added kind/deprecation Categorizes issue or PR as related to a feature/enhancement marked for deprecation. area/cli and removed area/UX labels Apr 18, 2024
@sftim
Copy link

sftim commented Apr 18, 2024

add a new flag --output that also does the same thing

Could we do that part in a v1.30 patch release? Any reason why we couldn't?

@neolit123
Copy link
Member Author

add a new flag --output that also does the same thing

Could we do that part in a v1.30 patch release? Any reason why we couldn't?

not a bugfix, thus can't be advocated for.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area/cli kind/deprecation Categorizes issue or PR as related to a feature/enhancement marked for deprecation. kind/feature Categorizes issue or PR as related to a new feature. priority/important-soon Must be staffed and worked on either currently, or very soon, ideally in time for the next release.
Projects
None yet
Development

No branches or pull requests

3 participants