New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update kubeadm reference for v1.30 #45911
Conversation
✅ Pull request preview available for checking
To edit notification comments on pull requests, go to your Netlify site configuration. |
/approve |
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: sftim The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@@ -30,6 +30,13 @@ kubeadm certs check-expiration [flags] | |||
</colgroup> | |||
<tbody> | |||
|
|||
<tr> | |||
<td colspan="2">--allow-missing-template-keys Default: true</td> |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
this should not be a kubeadm flag, we need to understand what is going on here.
https://github.com/search?q=repo%3Akubernetes%2Fkubernetes%20allow-missing-template-keys&type=code
@@ -44,6 +51,13 @@ kubeadm certs check-expiration [flags] | |||
<td></td><td style="line-height: 130%; word-wrap: break-word;"><p>Path to a kubeadm configuration file.</p></td> | |||
</tr> | |||
|
|||
<tr> | |||
<td colspan="2">-o, --experimental-output string Default: "text"</td> |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
ditto
@@ -58,6 +72,13 @@ kubeadm certs check-expiration [flags] | |||
<td></td><td style="line-height: 130%; word-wrap: break-word;"><p>The kubeconfig file to use when talking to the cluster. If the flag is not set, a set of standard locations can be searched for an existing kubeconfig file.</p></td> | |||
</tr> | |||
|
|||
<tr> | |||
<td colspan="2">--show-managed-fields</td> |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
ditto.
looks like all kubeadm commands with structured output now have these extra flags allow-missing-template-keys , --show-managed-fields also wasn't --experimental-output just --output? i'm trying to find where these changes happened.
|
never mind, it seems this has been the case: so we never graduated our --experimental-output flag to just --output. i will log a ticket for 1.31 for that. /lgtm |
LGTM label has been added. Git tree hash: 0964ec5dc81b547a635544042efe3ef91e227ef1
|
@neolit123 The
when I (re)implement kubernetes/kubernetes#123372 and According to kubernetes/kubernetes#123372, it accepts Go template as output. |
yes, i got confused. |
No description provided.