Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Create unit tests for uploadconfigphase #379

Closed
pipejakob opened this issue Aug 10, 2017 · 4 comments
Closed

Create unit tests for uploadconfigphase #379

pipejakob opened this issue Aug 10, 2017 · 4 comments
Assignees
@medinatiger
Labels
area/test kind/cleanup Categorizes issue or PR as related to cleaning up code, process, or technical debt.
Milestone
v1.9

Comments

@pipejakob
Copy link
Contributor

Due to time constraints, the uploadconfigphase code was merged without any automated testing. It should have basic unit tests as well as idempotency tests to ensure that kubeadm init can still be used for upgrades, since that process requires that all of the phases in the init flow are idempotent.
@pipejakob pipejakob added area/test kind/cleanup Categorizes issue or PR as related to cleaning up code, process, or technical debt. labels Aug 10, 2017
@luxas luxas self-assigned this Aug 14, 2017
@luxas
Copy link
Member

luxas commented Aug 14, 2017

As agreed, I'll take this follow up

@pipejakob
Copy link
Contributor Author

It's possible that @medinatiger was going to pick this up as a starter task. Can you two sync up to make sure we don't duplicate the work?

@luxas
Copy link
Member

luxas commented Aug 14, 2017 via email

@medinatiger
Copy link

@luxas I will start to work on this very soon

@luxas luxas assigned medinatiger and unassigned luxas Aug 19, 2017
@medinatiger medinatiger mentioned this issue Aug 30, 2017
Merged
k8s-github-robot pushed a commit to kubernetes/kubernetes that referenced this issue Sep 1, 2017
Merge pull request #51482 from medinatiger/dev
7da7126 
Automatic merge from submit-queue (batch tested with PRs 51513, 51515, 50570, 51482, 51448)

Add unit test for UploadConfig in Kubeadm

**What this PR does / why we need it**:
This is PR add unit test for UploadConfig refactoring which saved the master configuration used for init into ConfigMap for later use
**Which issue this PR fixes** *(optional, in `fixes #<issue number>(, fixes #<issue_number>, ...)` format, will close that issue when PR gets merged)*: fixes #kubernetes/kubeadm#379

**Special notes for your reviewer**:

**Release note**:

```release-note
NONE
```
@luxas luxas added this to the v1.9 milestone Sep 22, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@medinatiger medinatiger

Labels
area/test kind/cleanup Categorizes issue or PR as related to cleaning up code, process, or technical debt.
Projects
None yet
Milestone
v1.9
Development

No branches or pull requests
3 participants
@pipejakob @luxas @medinatiger