Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

kubeadm upgrade plan output should also print required flags #935

Closed
chuckha opened this issue Jun 18, 2018 · 2 comments · Fixed by kubernetes/kubernetes#65802
Closed

kubeadm upgrade plan output should also print required flags #935

chuckha opened this issue Jun 18, 2018 · 2 comments · Fixed by kubernetes/kubernetes#65802
Assignees
@xlgao-zju
Labels
area/UX kind/bug Categorizes issue or PR as related to a bug. kind/cleanup Categorizes issue or PR as related to cleaning up code, process, or technical debt.
Milestone
v1.12

Comments

@chuckha
Copy link

chuckha commented Jun 18, 2018

Is this a BUG REPORT or FEATURE REQUEST?

BUG REPORT

Versions

Upgrading k8s from 1.10.4 to 1.11.0-beta.2

kubeadm version (use kubeadm version):
kubeadm version: &version.Info{Major:"1", Minor:"11+", GitVersion:"v1.11.0-beta.2.57+8bb1309efed13d-dirty", GitCommit:"8bb1309efed13d572c12bf29397e533e07579b56", GitTreeState:"dirty", BuildDate:"2018-06-12T19:00:36Z", GoVersion:"go1.10.2", Compiler:"gc", Platform:"linux/amd64"}

What happened?

I ran kubeadm upgrade plan --allow-experimental-upgrades

and received the line

You can now apply the upgrade by executing the following command:

        kubeadm upgrade apply v1.11.0-beta.2

Note: Before you can perform this upgrade, you have to update kubeadm to v1.11.0-beta.2.

I then ran kubeadm upgrade apply v1.11.0-beta.2 and received an error:

[upgrade/version] FATAL: The --version argument is invalid due to these errors:

        - Specified version to upgrade to "v1.11.0-beta.2" is an unstable version and such upgrades weren't allowed via setting the --allow-*-upgrades flags

What you expected to happen?

I expected to run the provided command without errors.

How to reproduce it (as minimally and precisely as possible)?

upgrade to a non-stable release version

Anything else we need to know?
@chuckha chuckha added kind/bug Categorizes issue or PR as related to a bug. kind/cleanup Categorizes issue or PR as related to cleaning up code, process, or technical debt. area/UX labels Jun 18, 2018
@chuckha chuckha added this to the v1.12 milestone Jun 18, 2018
@neolit123
Copy link
Member

/assign
i can take this. if someone else wants it - do tell. :)

@neolit123 neolit123 mentioned this issue Jun 27, 2018
Closed
@xlgao-zju
Copy link

/assign
@neolit123 Thank you for your suggestion of taking this. I'd love to help this. 😆

@neolit123 neolit123 removed their assignment Jun 28, 2018
@xlgao-zju xlgao-zju mentioned this issue Jul 4, 2018
Merged
k8s-github-robot pushed a commit to kubernetes/kubernetes that referenced this issue Jul 7, 2018
Merge pull request #65802 from xlgao-zju/improve-output
2d288a7 
Automatic merge from submit-queue. If you want to cherry-pick this change to another branch, please follow the instructions <a href="https://github.com/kubernetes/community/blob/master/contributors/devel/cherry-picks.md">here</a>.

[kubeadm] Print required flags when running kubeadm upgrade plan

**What this PR does / why we need it**:
print required flags when running kubeadm upgrade plan

**Which issue(s) this PR fixes** *(optional, in `fixes #<issue number>(, fixes #<issue_number>, ...)` format, will close the issue(s) when PR gets merged)*:
Close [kubernetes/kubeadm#935](kubernetes/kubeadm#935)

**Special notes for your reviewer**:
/assign @chuckha 
/assign @neolit123 

**Release note**:

```release-note
kubeadm: print required flags when running kubeadm upgrade plan
```
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@xlgao-zju xlgao-zju

Labels
area/UX kind/bug Categorizes issue or PR as related to a bug. kind/cleanup Categorizes issue or PR as related to cleaning up code, process, or technical debt.
Projects
None yet
Milestone
v1.12
Development

Successfully merging a pull request may close this issue.

[kubeadm] Print required flags when running kubeadm upgrade plan xlgao-zju/kubernetes
3 participants
@chuckha @neolit123 @xlgao-zju