Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

make kinder refer to "kinder get kubeconfig-path" #1888

Merged
merged 1 commit into from Nov 6, 2019
Merged

make kinder refer to "kinder get kubeconfig-path" #1888

merged 1 commit into from Nov 6, 2019

Conversation

dholbach
Copy link
Member

@dholbach dholbach commented Nov 6, 2019

It referred to kind, which might have been a small typo or mistake.

In any case it's one tool less to install and you can just copy and paste what's on the screen.

make kinder refer to "kinder get kubeconfig-path"
49a06ec 
	It referred to kind, which might have been a small typo
	or mistake.

	In any case it's one tool less to install and you can
	just copy and paste what's on the screen.

Signed-off-by: Daniel Holbach <daniel@weave.works>
@k8s-ci-robot k8s-ci-robot added cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. sig/cluster-lifecycle Categorizes an issue or PR as relevant to SIG Cluster Lifecycle. labels Nov 6, 2019
@neolit123
Copy link
Member

@dholbach hi, curious where/how are you using kinder?
thanks for the PR.
/lgtm
/approve

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Nov 6, 2019
@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: dholbach, neolit123

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Nov 6, 2019
@k8s-ci-robot k8s-ci-robot merged commit 4859d80 into kubernetes:master Nov 6, 2019
@dholbach
Copy link
Member Author

dholbach commented Nov 6, 2019

Hey @neolit123 - thanks for the super-fast PR review! <3

@stealthybox recommended kinder for a small demo I'm putting together. I'm happy to share it once it got anywhere. It's looking good so far!

@dholbach dholbach deleted the swap-kind-to-kinder branch November 6, 2019 14:53
@neolit123
Copy link
Member

thanks @dholbach , understood.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ereslibre ereslibre Awaiting requested review from ereslibre

@fabriziopandini fabriziopandini Awaiting requested review from fabriziopandini

Assignees

@neolit123 neolit123

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. lgtm "Looks good to me", indicates that a PR is ready to be merged. sig/cluster-lifecycle Categorizes an issue or PR as relevant to SIG Cluster Lifecycle. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@dholbach @neolit123 @k8s-ci-robot