kinder: remove 1.15 logic and workflows #2248
Conversation
- --upload-certs vs --experimental-upload-certs - pass certificate key via config (no --certificate-key usage) - use "kubeadm upgrade node" with detection
The latest-1.15.txt version label/marker was removed due to GCS "retention" (not updated for some time) and these jobs started failing.
k8s-ci-robot
added
cncf-cla: yes
k8s-ci-robot
added
sig/cluster-lifecycle
|
/assign @fabriziopandini |
k8s-ci-robot
added
area/kinder
| fmt.Sprintf("--config=%s", constants.KubeadmConfigPath), | ||
| fmt.Sprintf("--v=%d", vLevel), | ||
| } | ||
| if automaticCopyCerts { |
There was a problem hiding this comment.
this seems to be checked already above.
just appending the flag --upload-certs to uploadCertsArgs seems sufficient here.
| // if before v1.15, add certificate key flag (for >= 15, certificate key is passed via the config file) | ||
| if cp.MustKubeadmVersion().LessThan(constants.V1_15) { | ||
| joinArgs = append(joinArgs, | ||
| fmt.Sprintf("--certificate-key=%s", constants.CertificateKey), |
There was a problem hiding this comment.
making our e2e prefer config seems fine.
| ).RunWithEcho(); err != nil { | ||
| return err | ||
| } | ||
| // kubeadm upgrade node |
There was a problem hiding this comment.
this is copied from the if n.MustKubeadmVersion().AtLeast(constants.V1_15) { branch.
| @@ -107,12 +107,6 @@ const ( | |||
|
|
|||
| // kubernetes releases, used for branching code according to K8s release or kubeadm release version | |||
| var ( | |||
| // V1_13 minor version | |||
| V1_13 = K8sVersion.MustParseSemantic("v1.13.0-0") | |||
There was a problem hiding this comment.
stray, unused version constant.
|
/retest |
| @@ -74,10 +73,6 @@ func getKubeadmConfigVersion(kubeadmVersion *K8sVersion.Version) (string, error) | |||
| // v1alpha2 (that is Kuberntes v1.11.0) is out of support. | |||
| // v1alpha3 (that is Kuberntes v1.13.0) is out of support. | |||
|
|
|||
| if kubeadmVersion.LessThan(constants.V1_15) { | |||
| return "v1beta1", nil | |||
There was a problem hiding this comment.
@neolit123 the fact we are removing "v1beta1" from the kubeadm test grid is kind of worrying because it is still used in CAPI.
We should consider adding a flag for forcing the config version to use and add dedicated tests for this (v1.16 with v1beta1, v1.17 with v1beta1 etc), but this is out of scope of this PR.
In the meantime, let's preserve int the code configTemplateBetaV1
There was a problem hiding this comment.
i will comment on #2249
k8s-ci-robot
added
the
lgtm
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: fabriziopandini, neolit123 The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
|
/retitle kinder: remove 1.15 logic and workflows |
k8s-ci-robot
changed the title
The latest-1.15.txt version label/marker was removed
due to GCS "retention" (not updated for some time)
and these jobs started failing.