Umbrella Issue: refactor commands to split flags from options

[soltysh]

Currently most or even all of the commands have an *Options structure holding all of the data needed to run a command and three main methods Complete (finishing *Options struct), Validate (validating *Options struct) and Run (actual code behind the command). The current problem is that these *Options struct is tightly coupled with flags, but we'd like to split these.

A perfect example is wait command.

This issue should serve as a synchronization point.

/cc @eddiezane @seans3

[soltysh]

/triage accepted

[eddiezane]

/remove-help
/remote-good-first-issue

Holding off on this until we scope better and trial a few to confirm it's what we want.

[eddiezane]

@soltysh looking at logs and get

[eddiezane]

@rikatz will take basic create

[eddiezane]

@KnVerey to look at drain or describe

[eddiezane]

@eddiezane will look at a simple config command

[rikatz]

/assign
So I wont forget :)

[lauchokyip]

Will do create with @rikatz synchronously

[SaiHarshaK]

/assign
I'll try to do for apply command

[ihcsim]

/assign

[ihcsim]

i can do attach.

[pacoxu]

A simple summary:

• - wait ✅ a perfect example
• - [WIP]create @lauchokyip & rikatz Refactor create commands to split flags from options kubernetes#101736
• - logs and get @soltysh
• - apply @SaiHarshaK
• - config @eddiezane
• - drain/describe @KnVerey
• - attach @ihcsim
• - scale @BigaDev

[eddiezane]

@BigaDev will take a look at scale

[eddiezane]

@pacoxu thanks for the summary!

I want to make sure folks understand that this will be a bit of an iteration process while we dial in exactly what we want these to look like. Expect some refactors and potential rewrites.

[PuneetPunamiya]

I'll refactor explain :)

[varksvader]

Hey! I was wondering if you guys needed more help on this issue. I'm happy to pick up a command and start working on it.

[varksvader]

/assign

Talked to owner of issue. Grabbing drain to refactor.

[harshitasao]

I'll refactor create
/assign

[lauchokyip]

@harshitasao , I think I finished create a while ago (kubernetes/kubernetes#101736), just waiting for review, would you be able to pick other command to refactor instead?

[k8s-ci-robot]

@brunopecampos: GitHub didn't allow me to assign the following users: brunopecampos.

Note that only kubernetes members with read permissions, repo collaborators and people who have commented on this issue/PR can be assigned. Additionally, issues/PRs can only have 10 assignees at the same time.
For more information please see the contributor guide

In response to this:

/assign

I'll do diff

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

[jaehnri]

/unassign

We hit the 10 assignees limit. Unassigning so Bruno can do diff :)

[brunopecampos]

/assign

I'll do diff

[varshaprasad96]

I can work on the refactoring of expose command.

[gxwilkerson33]

@eddiezane @soltysh Do we have a list of commands that still need this refactoring?

[gxwilkerson33]

@soltysh @eddiezane I am working on refactoring of Run command. Currently id does not follow Complete, Validate, Run. Validate seems to be being handled within the Run function. Should i make that refactor also, to make Validate function and remove this functionality from the Run function?

[k8s-triage-robot]

This issue has not been updated in over 1 year, and should be re-triaged.

You can:

• Confirm that this issue is still relevant with /triage accepted (org members only)
• Close this issue with /close

For more details on the triage process, see https://www.kubernetes.dev/docs/guide/issue-triage/

/remove-triage accepted