Skip to content
This repository has been archived by the owner on Apr 22, 2020. It is now read-only.

phase1: bump docker version to 1.13.1 #579

Merged
merged 1 commit into from Jan 14, 2019
Merged

phase1: bump docker version to 1.13.1 #579

merged 1 commit into from Jan 14, 2019

Conversation

neolit123
Copy link
Contributor

this PR bumped the minimum docker version in the kubelet and turned our e2e tests red:
kubernetes/kubernetes#72831
https://gubernator.k8s.io/build/kubernetes-jenkins/logs/ci-kubernetes-e2e-kubeadm-gce-master/1519

i have tested the change in a xenial container.

/assign @fabriziopandini
/cc @timothysc @mauilion

@neolit123 neolit123 added kind/bug Categorizes issue or PR as related to a bug. priority/critical-urgent Highest priority. Must be actively worked on as someone's top priority right now. labels Jan 12, 2019
@k8s-ci-robot k8s-ci-robot added the cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. label Jan 12, 2019
@k8s-ci-robot
Copy link
Contributor

@neolit123: GitHub didn't allow me to request PR reviews from the following users: mauilion.

Note that only kubernetes members and repo collaborators can review this PR, and authors cannot review their own PRs.

In response to this:

this PR bumped the minimum docker version in the kubelet and turned our e2e tests red:
kubernetes/kubernetes#72831
https://gubernator.k8s.io/build/kubernetes-jenkins/logs/ci-kubernetes-e2e-kubeadm-gce-master/1519

i have tested the change in a xenial container.

/assign @fabriziopandini
/cc @timothysc @mauilion

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: neolit123

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added approved Indicates a PR has been approved by an approver from all required OWNERS files. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. labels Jan 12, 2019
@fabriziopandini
Copy link

/lgtm

@k8s-ci-robot k8s-ci-robot added the lgtm Indicates that a PR is ready to be merged. label Jan 14, 2019
@k8s-ci-robot k8s-ci-robot merged commit 335e5d1 into kubernetes-retired:kubeadm-e2e Jan 14, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@timothysc timothysc Awaiting requested review from timothysc

Assignees

@fabriziopandini fabriziopandini

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. kind/bug Categorizes issue or PR as related to a bug. lgtm Indicates that a PR is ready to be merged. priority/critical-urgent Highest priority. Must be actively worked on as someone's top priority right now. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@neolit123 @k8s-ci-robot @fabriziopandini