Skip to content

Commit

Permalink
spdyroundtripper: d tlson't verify hostname twice
Browse files Browse the repository at this point in the history
  • Loading branch information
aojea committed May 3, 2022
1 parent 6d14c8e commit 00a6042
Showing 1 changed file with 0 additions and 27 deletions.
Original file line number Diff line number Diff line change
Expand Up @@ -264,21 +264,11 @@ func (s *SpdyRoundTripper) tlsConn(ctx context.Context, rwc net.Conn, targetHost

tlsConn := tls.Client(rwc, tlsConfig)

// need to manually call Handshake() so we can call VerifyHostname() below
if err := tlsConn.HandshakeContext(ctx); err != nil {
tlsConn.Close()
return nil, err
}

// Return if we were configured to skip validation
if tlsConfig.InsecureSkipVerify {
return tlsConn, nil
}

if err := tlsConn.VerifyHostname(tlsConfig.ServerName); err != nil {
return nil, err
}

return tlsConn, nil
}

Expand Down Expand Up @@ -307,23 +297,6 @@ func (s *SpdyRoundTripper) dialWithoutProxy(ctx context.Context, url *url.URL) (
return nil, err
}

// Return if we were configured to skip validation
if s.tlsConfig != nil && s.tlsConfig.InsecureSkipVerify {
return conn, nil
}

host, _, err := net.SplitHostPort(dialAddr)
if err != nil {
return nil, err
}
if s.tlsConfig != nil && len(s.tlsConfig.ServerName) > 0 {
host = s.tlsConfig.ServerName
}
err = conn.VerifyHostname(host)
if err != nil {
return nil, err
}

return conn, nil
}

Expand Down

0 comments on commit 00a6042

Please sign in to comment.