Skip to content

Commit

Permalink
Merge pull request #32100 from wojtek-t/fix_rc_log
Browse files Browse the repository at this point in the history
Automatic merge from submit-queue

Fix debugging log in RC

Ref #31981
  • Loading branch information
Kubernetes Submit Queue committed Sep 6, 2016
2 parents 0c8b178 + 5582856 commit 065fad7
Showing 1 changed file with 2 additions and 1 deletion.
3 changes: 2 additions & 1 deletion pkg/controller/replication/replication_controller.go
Original file line number Diff line number Diff line change
Expand Up @@ -320,7 +320,7 @@ func (rm *ReplicationManager) updateRC(old, cur interface{}) {
rm.lookupCache.InvalidateAll()
}
// TODO: Remove when #31981 is resolved!
glog.Infof("Observed updated replication controller %v. Pod count change: %d->%d", curRC.Name, oldRC.Status.Replicas, curRC.Status.Replicas)
glog.Infof("Observed updated replication controller %v. Desired pod count change: %d->%d", curRC.Name, oldRC.Spec.Replicas, curRC.Spec.Replicas)

// You might imagine that we only really need to enqueue the
// controller when Spec changes, but it is safer to sync any
Expand All @@ -335,6 +335,7 @@ func (rm *ReplicationManager) updateRC(old, cur interface{}) {
// that bad as rcs that haven't met expectations yet won't
// sync, and all the listing is done using local stores.
if oldRC.Status.Replicas != curRC.Status.Replicas {
// TODO: Should we log status or spec?
glog.V(4).Infof("Observed updated replica count for rc: %v, %d->%d", curRC.Name, oldRC.Status.Replicas, curRC.Status.Replicas)
}
rm.enqueueController(cur)
Expand Down

0 comments on commit 065fad7

Please sign in to comment.