Skip to content

Commit

Permalink
Merge pull request #44774 from kargakis/uniquifier
Browse files Browse the repository at this point in the history
Automatic merge from submit-queue

Switch Deployments to new hashing algo w/ collision avoidance mechanism

Implements kubernetes/community#477

@kubernetes/sig-apps-api-reviews @kubernetes/sig-apps-pr-reviews 

Fixes #29735
Fixes #43948

```release-note
Deployments are updated to use (1) a more stable hashing algorithm (fnv) than the previous one (adler) and (2) a hashing collision avoidance mechanism that will ensure new rollouts will not block on hashing collisions anymore.
```
  • Loading branch information
Kubernetes Submit Queue committed May 25, 2017
2 parents 9c1480b + 9190a47 commit 26d7ee0
Show file tree
Hide file tree
Showing 57 changed files with 1,885 additions and 1,093 deletions.
10 changes: 10 additions & 0 deletions api/openapi-spec/swagger.json
Original file line number Diff line number Diff line change
Expand Up @@ -47259,6 +47259,11 @@
"type": "integer",
"format": "int32"
},
"collisionCount": {
"description": "Count of hash collisions for the Deployment. The Deployment controller uses this field as a collision avoidance mechanism when it needs to create the name for the newest ReplicaSet.",
"type": "integer",
"format": "int64"
},
"conditions": {
"description": "Represents the latest available observations of a deployment's current state.",
"type": "array",
Expand Down Expand Up @@ -49477,6 +49482,11 @@
"type": "integer",
"format": "int32"
},
"collisionCount": {
"description": "Count of hash collisions for the Deployment. The Deployment controller uses this field as a collision avoidance mechanism when it needs to create the name for the newest ReplicaSet.",
"type": "integer",
"format": "int64"
},
"conditions": {
"description": "Represents the latest available observations of a deployment's current state.",
"type": "array",
Expand Down
5 changes: 5 additions & 0 deletions api/swagger-spec/apps_v1beta1.json
Original file line number Diff line number Diff line change
Expand Up @@ -4706,6 +4706,11 @@
"$ref": "v1beta1.DeploymentCondition"
},
"description": "Represents the latest available observations of a deployment's current state."
},
"collisionCount": {
"type": "integer",
"format": "int64",
"description": "Count of hash collisions for the Deployment. The Deployment controller uses this field as a collision avoidance mechanism when it needs to create the name for the newest ReplicaSet."
}
}
},
Expand Down
5 changes: 5 additions & 0 deletions api/swagger-spec/extensions_v1beta1.json
Original file line number Diff line number Diff line change
Expand Up @@ -9408,6 +9408,11 @@
"$ref": "v1beta1.DeploymentCondition"
},
"description": "Represents the latest available observations of a deployment's current state."
},
"collisionCount": {
"type": "integer",
"format": "int64",
"description": "Count of hash collisions for the Deployment. The Deployment controller uses this field as a collision avoidance mechanism when it needs to create the name for the newest ReplicaSet."
}
}
},
Expand Down
9 changes: 8 additions & 1 deletion docs/api-reference/apps/v1beta1/definitions.html
Original file line number Diff line number Diff line change
Expand Up @@ -466,6 +466,13 @@ <h3 id="_v1beta1_deploymentstatus">v1beta1.DeploymentStatus</h3>
<td class="tableblock halign-left valign-top"><p class="tableblock"><a href="#_v1beta1_deploymentcondition">v1beta1.DeploymentCondition</a> array</p></td>
<td class="tableblock halign-left valign-top"></td>
</tr>
<tr>
<td class="tableblock halign-left valign-top"><p class="tableblock">collisionCount</p></td>
<td class="tableblock halign-left valign-top"><p class="tableblock">Count of hash collisions for the Deployment. The Deployment controller uses this field as a collision avoidance mechanism when it needs to create the name for the newest ReplicaSet.</p></td>
<td class="tableblock halign-left valign-top"><p class="tableblock">false</p></td>
<td class="tableblock halign-left valign-top"><p class="tableblock">integer (int64)</p></td>
<td class="tableblock halign-left valign-top"></td>
</tr>
</tbody>
</table>

Expand Down Expand Up @@ -6470,7 +6477,7 @@ <h3 id="_any">any</h3>
</div>
<div id="footer">
<div id="footer-text">
Last updated 2017-05-22 06:32:54 UTC
Last updated 2017-05-25 09:31:33 UTC
</div>
</div>
</body>
Expand Down
9 changes: 8 additions & 1 deletion docs/api-reference/extensions/v1beta1/definitions.html
Original file line number Diff line number Diff line change
Expand Up @@ -496,6 +496,13 @@ <h3 id="_v1beta1_deploymentstatus">v1beta1.DeploymentStatus</h3>
<td class="tableblock halign-left valign-top"><p class="tableblock"><a href="#_v1beta1_deploymentcondition">v1beta1.DeploymentCondition</a> array</p></td>
<td class="tableblock halign-left valign-top"></td>
</tr>
<tr>
<td class="tableblock halign-left valign-top"><p class="tableblock">collisionCount</p></td>
<td class="tableblock halign-left valign-top"><p class="tableblock">Count of hash collisions for the Deployment. The Deployment controller uses this field as a collision avoidance mechanism when it needs to create the name for the newest ReplicaSet.</p></td>
<td class="tableblock halign-left valign-top"><p class="tableblock">false</p></td>
<td class="tableblock halign-left valign-top"><p class="tableblock">integer (int64)</p></td>
<td class="tableblock halign-left valign-top"></td>
</tr>
</tbody>
</table>

Expand Down Expand Up @@ -8110,7 +8117,7 @@ <h3 id="_any">any</h3>
</div>
<div id="footer">
<div id="footer-text">
Last updated 2017-05-22 06:33:43 UTC
Last updated 2017-05-25 09:32:15 UTC
</div>
</div>
</body>
Expand Down
5 changes: 5 additions & 0 deletions federation/apis/openapi-spec/swagger.json
Original file line number Diff line number Diff line change
Expand Up @@ -13315,6 +13315,11 @@
"type": "integer",
"format": "int32"
},
"collisionCount": {
"description": "Count of hash collisions for the Deployment. The Deployment controller uses this field as a collision avoidance mechanism when it needs to create the name for the newest ReplicaSet.",
"type": "integer",
"format": "int64"
},
"conditions": {
"description": "Represents the latest available observations of a deployment's current state.",
"type": "array",
Expand Down
5 changes: 5 additions & 0 deletions federation/apis/swagger-spec/extensions_v1beta1.json
Original file line number Diff line number Diff line change
Expand Up @@ -7152,6 +7152,11 @@
"$ref": "v1beta1.DeploymentCondition"
},
"description": "Represents the latest available observations of a deployment's current state."
},
"collisionCount": {
"type": "integer",
"format": "int64",
"description": "Count of hash collisions for the Deployment. The Deployment controller uses this field as a collision avoidance mechanism when it needs to create the name for the newest ReplicaSet."
}
}
},
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -478,6 +478,13 @@ <h3 id="_v1beta1_deploymentstatus">v1beta1.DeploymentStatus</h3>
<td class="tableblock halign-left valign-top"><p class="tableblock"><a href="#_v1beta1_deploymentcondition">v1beta1.DeploymentCondition</a> array</p></td>
<td class="tableblock halign-left valign-top"></td>
</tr>
<tr>
<td class="tableblock halign-left valign-top"><p class="tableblock">collisionCount</p></td>
<td class="tableblock halign-left valign-top"><p class="tableblock">Count of hash collisions for the Deployment. The Deployment controller uses this field as a collision avoidance mechanism when it needs to create the name for the newest ReplicaSet.</p></td>
<td class="tableblock halign-left valign-top"><p class="tableblock">false</p></td>
<td class="tableblock halign-left valign-top"><p class="tableblock">integer (int64)</p></td>
<td class="tableblock halign-left valign-top"></td>
</tr>
</tbody>
</table>

Expand Down Expand Up @@ -7190,7 +7197,7 @@ <h3 id="_any">any</h3>
</div>
<div id="footer">
<div id="footer-text">
Last updated 2017-05-22 07:30:41 UTC
Last updated 2017-05-25 09:37:16 UTC
</div>
</div>
</body>
Expand Down
Loading

0 comments on commit 26d7ee0

Please sign in to comment.