Skip to content

Commit

Permalink
Merge pull request #84235 from liggitt/extensions-v1-coverage
Browse files Browse the repository at this point in the history
Use v1 CRD deletion endpoints in e2e tests
  • Loading branch information
k8s-ci-robot committed Oct 24, 2019
2 parents 6d4aecc + c6fe4f0 commit 31b7e3d
Show file tree
Hide file tree
Showing 2 changed files with 2 additions and 2 deletions.
Original file line number Diff line number Diff line change
Expand Up @@ -523,7 +523,7 @@ func DeleteCustomResourceDefinition(crd *apiextensionsv1beta1.CustomResourceDefi

// DeleteV1CustomResourceDefinition deletes a CRD and waits until it disappears from discovery.
func DeleteV1CustomResourceDefinition(crd *apiextensionsv1.CustomResourceDefinition, apiExtensionsClient clientset.Interface) error {
if err := apiExtensionsClient.ApiextensionsV1beta1().CustomResourceDefinitions().Delete(crd.Name, nil); err != nil {
if err := apiExtensionsClient.ApiextensionsV1().CustomResourceDefinitions().Delete(crd.Name, nil); err != nil {
return err
}
for _, version := range servedV1Versions(crd) {
Expand Down
2 changes: 1 addition & 1 deletion test/e2e/apimachinery/custom_resource_definition.go
Original file line number Diff line number Diff line change
Expand Up @@ -121,7 +121,7 @@ var _ = SIGDescribe("CustomResourceDefinition resources [Privileged:ClusterAdmin
}

// Use delete collection to remove the CRDs
err = fixtures.DeleteCustomResourceDefinitions(selectorListOpts, apiExtensionClient)
err = fixtures.DeleteV1CustomResourceDefinitions(selectorListOpts, apiExtensionClient)
framework.ExpectNoError(err, "deleting CustomResourceDefinitions")
_, err = apiExtensionClient.ApiextensionsV1().CustomResourceDefinitions().Get(crd.Name, metav1.GetOptions{})
framework.ExpectNoError(err, "getting remaining CustomResourceDefinition")
Expand Down

0 comments on commit 31b7e3d

Please sign in to comment.