Skip to content

Commit

Permalink
core/v1: remove note about hostAliases not working with hostNetwork
Browse files Browse the repository at this point in the history
Support for this was added in 1.8 by PR 50646.
Local tests confirm that the feature indeed works.
E2e tests seem to be missing.
  • Loading branch information
neolit123 committed Dec 20, 2023
1 parent 38f4f9d commit 47ee56a
Show file tree
Hide file tree
Showing 9 changed files with 9 additions and 9 deletions.
2 changes: 1 addition & 1 deletion api/openapi-spec/swagger.json

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

2 changes: 1 addition & 1 deletion api/openapi-spec/v3/api__v1_openapi.json
Original file line number Diff line number Diff line change
Expand Up @@ -5307,7 +5307,7 @@
"x-kubernetes-patch-strategy": "merge"
},
"hostAliases": {
"description": "HostAliases is an optional list of hosts and IPs that will be injected into the pod's hosts file if specified. This is only valid for non-hostNetwork pods.",
"description": "HostAliases is an optional list of hosts and IPs that will be injected into the pod's hosts file if specified.",
"items": {
"allOf": [
{
Expand Down
2 changes: 1 addition & 1 deletion api/openapi-spec/v3/apis__apps__v1_openapi.json
Original file line number Diff line number Diff line change
Expand Up @@ -3724,7 +3724,7 @@
"x-kubernetes-patch-strategy": "merge"
},
"hostAliases": {
"description": "HostAliases is an optional list of hosts and IPs that will be injected into the pod's hosts file if specified. This is only valid for non-hostNetwork pods.",
"description": "HostAliases is an optional list of hosts and IPs that will be injected into the pod's hosts file if specified.",
"items": {
"allOf": [
{
Expand Down
2 changes: 1 addition & 1 deletion api/openapi-spec/v3/apis__batch__v1_openapi.json
Original file line number Diff line number Diff line change
Expand Up @@ -2879,7 +2879,7 @@
"x-kubernetes-patch-strategy": "merge"
},
"hostAliases": {
"description": "HostAliases is an optional list of hosts and IPs that will be injected into the pod's hosts file if specified. This is only valid for non-hostNetwork pods.",
"description": "HostAliases is an optional list of hosts and IPs that will be injected into the pod's hosts file if specified.",
"items": {
"allOf": [
{
Expand Down
2 changes: 1 addition & 1 deletion pkg/apis/core/types.go
Original file line number Diff line number Diff line change
Expand Up @@ -3255,7 +3255,7 @@ type PodSpec struct {
// +optional
Tolerations []Toleration
// HostAliases is an optional list of hosts and IPs that will be injected into the pod's hosts
// file if specified. This is only valid for non-hostNetwork pods.
// file if specified.
// +optional
HostAliases []HostAlias
// If specified, indicates the pod's priority. "system-node-critical" and
Expand Down
2 changes: 1 addition & 1 deletion pkg/generated/openapi/zz_generated.openapi.go

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

2 changes: 1 addition & 1 deletion staging/src/k8s.io/api/core/v1/generated.proto

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

2 changes: 1 addition & 1 deletion staging/src/k8s.io/api/core/v1/types.go
Original file line number Diff line number Diff line change
Expand Up @@ -3670,7 +3670,7 @@ type PodSpec struct {
// +listType=atomic
Tolerations []Toleration `json:"tolerations,omitempty" protobuf:"bytes,22,opt,name=tolerations"`
// HostAliases is an optional list of hosts and IPs that will be injected into the pod's hosts
// file if specified. This is only valid for non-hostNetwork pods.
// file if specified.
// +optional
// +patchMergeKey=ip
// +patchStrategy=merge
Expand Down

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

0 comments on commit 47ee56a

Please sign in to comment.