Skip to content

Commit

Permalink
Merge pull request #64524 from krzyzacy/release-1.10
Browse files Browse the repository at this point in the history
Automatic merge from submit-queue.

properly skip cadvisor proxy test

xref #64158

per #64158 (comment)

/assign @liggitt @AishSundar
  • Loading branch information
Kubernetes Submit Queue committed May 31, 2018
2 parents 4435309 + 541dfd6 commit 547d38b
Showing 1 changed file with 7 additions and 3 deletions.
10 changes: 7 additions & 3 deletions test/e2e/network/proxy.go
Expand Up @@ -85,9 +85,13 @@ var _ = SIGDescribe("Proxy", func() {
subresource.
*/
framework.ConformanceIt("should proxy logs on node using proxy subresource ", func() { nodeProxyTest(f, prefix+"/nodes/", "/proxy/logs/") })
if !skipCAdvisorProxyTests {
It("should proxy to cadvisor using proxy subresource", func() { nodeProxyTest(f, prefix+"/nodes/", ":4194/proxy/containers/") })
}

It("should proxy to cadvisor using proxy subresource", func() {
if skipCAdvisorProxyTests {
framework.Skipf("cadvisor proxy test removed on newer server version")
}
nodeProxyTest(f, prefix+"/nodes/", ":4194/proxy/containers/")
})

// using the porter image to serve content, access the content
// (of multiple pods?) from multiple (endpoints/services?)
Expand Down

0 comments on commit 547d38b

Please sign in to comment.