Skip to content

Commit

Permalink
Merge pull request #67370 from yue9944882/chore/fix-crd-establish-con…
Browse files Browse the repository at this point in the history
…troller-ratelimit

Automatic merge from submit-queue. If you want to cherry-pick this change to another branch, please follow the instructions <a href="https://github.com/kubernetes/community/blob/master/contributors/devel/cherry-picks.md">here</a>.

Forget ratelimit on success in crd establish controller

/kind bug
/area customresources
/sig api-machinery


**What this PR does / why we need it**:

The ratelimit is never cancelled even when CRD controller succesfully updated CRD
 
**Release note**:

```release-note
 Forget rate limit when CRD establish controller successfully updated CRD condition
```
  • Loading branch information
Kubernetes Submit Queue committed Aug 16, 2018
2 parents 59fdc02 + a8abeda commit 58d43ab
Showing 1 changed file with 1 addition and 0 deletions.
Original file line number Diff line number Diff line change
Expand Up @@ -99,6 +99,7 @@ func (ec *EstablishingController) processNextWorkItem() bool {

err := ec.syncFn(key.(string))
if err == nil {
ec.queue.Forget(key)
return true
}

Expand Down

0 comments on commit 58d43ab

Please sign in to comment.