Merge pull request #109966 from zhangxyjlu/config_validation_test

Add validation test for features.GracefulNodeShutdownBasedOnPodPriority
kubernetes · Aug 24, 2022 · 7025406 · 7025406
2 parents 3118a5d + 7375ba4
commit 7025406
Showing 1 changed file with 26 additions and 0 deletions.
diff --git a/pkg/kubelet/apis/config/validation/validation_test.go b/pkg/kubelet/apis/config/validation/validation_test.go
@@ -528,6 +528,32 @@ func TestValidateKubeletConfiguration(t *testing.T) {
 			},
 			errMsg: "tracing.endpoint: Invalid value: \"dn%2s://localhost:4317\": parse \"dn%2s://localhost:4317\": first path segment in URL cannot contain colon",
 		},
+		{
+			name: "invalid GracefulNodeShutdownBasedOnPodPriority",
+			configure: func(conf *kubeletconfig.KubeletConfiguration) *kubeletconfig.KubeletConfiguration {
+				conf.FeatureGates = map[string]bool{"GracefulNodeShutdownBasedOnPodPriority": true}
+				conf.ShutdownGracePeriodByPodPriority = []kubeletconfig.ShutdownGracePeriodByPodPriority{
+					{
+						Priority:                   0,
+						ShutdownGracePeriodSeconds: 0,
+					}}
+				return conf
+			},
+			errMsg: "invalid configuration: Cannot specify both shutdownGracePeriodByPodPriority and shutdownGracePeriod at the same time",
+		},
+		{
+			name: "Specifying shutdownGracePeriodByPodPriority without enable GracefulNodeShutdownBasedOnPodPriority",
+			configure: func(conf *kubeletconfig.KubeletConfiguration) *kubeletconfig.KubeletConfiguration {
+				conf.FeatureGates = map[string]bool{"GracefulNodeShutdownBasedOnPodPriority": false}
+				conf.ShutdownGracePeriodByPodPriority = []kubeletconfig.ShutdownGracePeriodByPodPriority{
+					{
+						Priority:                   0,
+						ShutdownGracePeriodSeconds: 0,
+					}}
+				return conf
+			},
+			errMsg: "invalid configuration: Specifying shutdownGracePeriodByPodPriority requires feature gate GracefulNodeShutdownBasedOnPodPriority",
+		},
 	}
 
 	for _, tc := range cases {