Skip to content

Commit

Permalink
Merge pull request #52476 from clamoriniere1A/bugfix/e2e_job_backoff_…
Browse files Browse the repository at this point in the history
…flaky

Automatic merge from submit-queue

Bugfix: Fix e2e Flaky Apps/Job BackoffLimit test

This fix is linked to the PR #51153 that introduce the `JobSpec.BackoffLimit`.

Previously the Timeout used in the test was too aggressive and generates flaky test execution. Now it used the default `framework.JobTimeout` used in others tests.



**What this PR does / why we need it**:
This PR should fix flaky "[sig-apps] Job should exceed backoffLimit" test, due to a too short timeout duration.

**Which issue this PR fixes** *(optional, in `fixes #<issue number>(, fixes #<issue_number>, ...)` format, will close that issue when PR gets merged)*: fixes #
fixes #51153 

**Special notes for your reviewer**:

**Release note**:

```release-note
```
  • Loading branch information
Kubernetes Submit Queue committed Sep 15, 2017
2 parents b5fbd71 + 0d7182f commit 87a1b5f
Showing 1 changed file with 1 addition and 1 deletion.
2 changes: 1 addition & 1 deletion test/e2e/apps/job.go
Original file line number Diff line number Diff line change
Expand Up @@ -181,7 +181,7 @@ var _ = SIGDescribe("Job", func() {
Expect(err).NotTo(HaveOccurred())
By("Ensuring job exceed backofflimit")

err = framework.WaitForJobFailure(f.ClientSet, f.Namespace.Name, job.Name, time.Duration(30)*time.Second, "BackoffLimitExceeded")
err = framework.WaitForJobFailure(f.ClientSet, f.Namespace.Name, job.Name, framework.JobTimeout, "BackoffLimitExceeded")
Expect(err).NotTo(HaveOccurred())

By("Checking that only one pod created and status is failed")
Expand Down

0 comments on commit 87a1b5f

Please sign in to comment.