Skip to content

Commit

Permalink
Merge pull request #118167 from neolit123/automated-cherry-pick-of-#1…
Browse files Browse the repository at this point in the history
…18150-origin-release-1.25

Automated cherry pick of #118150: kubeadm: remove function pointer comparison in phase test
  • Loading branch information
k8s-ci-robot committed Jun 30, 2023
2 parents 60a0b31 + 025abc0 commit a670be3
Showing 1 changed file with 0 additions and 6 deletions.
6 changes: 0 additions & 6 deletions cmd/kubeadm/app/cmd/phases/workflow/runner_test.go
Original file line number Diff line number Diff line change
Expand Up @@ -401,14 +401,8 @@ func TestBindToCommandArgRequirements(t *testing.T) {
continue
}

// Ensure it is the expected function
if reflect.ValueOf(cCmd.Args).Pointer() != reflect.ValueOf(args.args).Pointer() {
t.Error("The function pointers where not equal.")
}

// Test passing argument set
err := cCmd.Args(cCmd, args.pass)

if err != nil {
t.Errorf("command %s should validate the args: %v\n %v", cCmd.Name(), args.pass, err)
}
Expand Down

0 comments on commit a670be3

Please sign in to comment.