Skip to content

Commit

Permalink
Fix build break - Hyperkube image needs kubelet/kubectl
Browse files Browse the repository at this point in the history
`make quick-release-images KUBE_BUILD_CONFORMANCE=n` was broken since we
modified hyperkube to use actual binaries from a script. Temporarily
build the two additional binaries needed until we remove hyperkube image
completely. Added a TODO as a reminder
  • Loading branch information
dims committed Dec 13, 2019
1 parent 5b77616 commit bfd20c9
Showing 1 changed file with 3 additions and 0 deletions.
3 changes: 3 additions & 0 deletions build/release-images.sh
Expand Up @@ -30,6 +30,9 @@ if [[ "${KUBE_BUILD_CONFORMANCE}" =~ [yY] ]]; then
CMD_TARGETS="${CMD_TARGETS} ${KUBE_CONFORMANCE_IMAGE_TARGETS[*]}"
fi

# TODO(dims): Remove this when we get rid of hyperkube image
CMD_TARGETS="${CMD_TARGETS} cmd/kubelet cmd/kubectl"

kube::build::verify_prereqs
kube::build::build_image
kube::build::run_build_command make all WHAT="${CMD_TARGETS}" KUBE_BUILD_PLATFORMS="${KUBE_SERVER_PLATFORMS[*]}"
Expand Down

0 comments on commit bfd20c9

Please sign in to comment.