Merge pull request #104129 from adtac/cachemut-1.20

job controller: don't mutate shared cache object
kubernetes · Sep 1, 2021 · c42cf17 · c42cf17
2 parents b9d77cc + ff055c1
commit c42cf17
Showing 1 changed file with 2 additions and 1 deletion.
diff --git a/pkg/controller/job/job_controller.go b/pkg/controller/job/job_controller.go
@@ -460,7 +460,8 @@ func (jm *Controller) syncJob(key string) (bool, error) {
 		}
 		return false, err
 	}
-	job := *sharedJob
+	// make a copy so we don't mutate the shared cache
+	job := *sharedJob.DeepCopy()
 
 	// if job was finished previously, we don't want to redo the termination
 	if IsJobFinished(&job) {