Skip to content

Commit

Permalink
sample controller: enhance context support
Browse files Browse the repository at this point in the history
27a68ae introduced context support for events. Creating an event
broadcaster with context makes tests more resilient against leaking goroutines
when that context gets canceled at the end of a test and enables per-test
output via ktesting.

The New method already had a context, therefore no API changes are needed.
  • Loading branch information
pohly committed Apr 24, 2024
1 parent 0f06328 commit cfe9104
Showing 1 changed file with 1 addition and 1 deletion.
2 changes: 1 addition & 1 deletion staging/src/k8s.io/sample-controller/controller.go
Original file line number Diff line number Diff line change
Expand Up @@ -101,7 +101,7 @@ func NewController(
utilruntime.Must(samplescheme.AddToScheme(scheme.Scheme))
logger.V(4).Info("Creating event broadcaster")

eventBroadcaster := record.NewBroadcaster()
eventBroadcaster := record.NewBroadcaster(record.WithContext(ctx))
eventBroadcaster.StartStructuredLogging(0)
eventBroadcaster.StartRecordingToSink(&typedcorev1.EventSinkImpl{Interface: kubeclientset.CoreV1().Events("")})
recorder := eventBroadcaster.NewRecorder(scheme.Scheme, corev1.EventSource{Component: controllerAgentName})
Expand Down

0 comments on commit cfe9104

Please sign in to comment.