Skip to content

Commit

Permalink
Fix disruptive subPath test failures
Browse files Browse the repository at this point in the history
This PR fixes two distruptive subpath test failures.

1. disable --check-volume-lifecycle check
2. skip hostpath driver tests on graceful pod deletion test too.

See details in
#103651 (comment)

Change-Id: Ibecd051be865feea5f2a92d22ade848367400939
  • Loading branch information
jingxu97 committed Jul 27, 2021
1 parent 1a9ae34 commit f1e1f3a
Show file tree
Hide file tree
Showing 2 changed files with 8 additions and 3 deletions.
6 changes: 3 additions & 3 deletions test/e2e/storage/drivers/csi.go
Expand Up @@ -235,9 +235,9 @@ func (h *hostpathCSIDriver) PrepareTest(f *framework.Framework) (*storageframewo
// testsuites/volumelimits.go `should support volume limits`
// test.
"--maxvolumespernode=10",
// Enable volume lifecycle checks, to report failure if
// the volume is not unpublished / unstaged correctly.
"--check-volume-lifecycle=true",
// Disable volume lifecycle checks due to issue #103651
// TODO: enable this check once issue is resolved for csi-host-path driver.

This comment has been minimized.

Copy link
@pohly

pohly Sep 8, 2021

Contributor

@jingxu97 : is there an open issue for this TODO?

Such TODOs tend to get forgotten without an issue.

This comment has been minimized.

Copy link
@pohly

pohly Sep 8, 2021

Contributor

FWIW, this is a rather brute-force approach for solving one particular issue. This really should only be done temporarily.

This comment has been minimized.

Copy link
@pohly

pohly Sep 9, 2021

Contributor

See #104863

"--check-volume-lifecycle=false",
},
ProvisionerContainerName: "csi-provisioner",
SnapshotterContainerName: "csi-snapshotter",
Expand Down
5 changes: 5 additions & 0 deletions test/e2e/storage/testsuites/subpath.go
Expand Up @@ -342,6 +342,11 @@ func (s *subPathTestSuite) DefineTests(driver storageframework.TestDriver, patte
init()
defer cleanup()

if strings.HasPrefix(driverName, "hostPath") {
// TODO: This skip should be removed once #61446 is fixed
e2eskipper.Skipf("Driver %s does not support reconstruction, skipping", driverName)
}

testSubpathReconstruction(f, l.hostExec, l.pod, false)
})

Expand Down

0 comments on commit f1e1f3a

Please sign in to comment.