Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

EndpointSlice Controllers create duplicate EndpointSlices in certain cases #100033

Closed
robscott opened this issue Mar 9, 2021 · 4 comments · Fixed by #100103
Closed

EndpointSlice Controllers create duplicate EndpointSlices in certain cases #100033

robscott opened this issue Mar 9, 2021 · 4 comments · Fixed by #100103
Assignees
@robscott
Labels
kind/bug Categorizes issue or PR as related to a bug. sig/network Categorizes an issue or PR as relevant to SIG Network. triage/accepted Indicates an issue or PR is ready to be actively worked on.

Comments

@robscott
Copy link
Member

robscott commented Mar 9, 2021 •
edited

What happened:

The controllers can create a second EndpointSlice after an immediate sync if the first EndpointSlice they created is not in the cache yet. Here's what can happen:

  1. Controller gets event that triggers sync for Service
  2. Controller syncs and creates EndpointSlice
  3. Controller gets event that triggers sync for same Service
  4. Controller syncs and creates EndpointSlice (the slice created in 2 has not made it to the cache yet)

What you expected to happen:

A single EndpointSlice to be created.

How to reproduce it (as minimally and precisely as possible):

Run integration tests hundreds of times that involve 2 consecutive events that will trigger a sync. Example: #100025 (comment).

/assign
/sig network
@robscott robscott added the kind/bug Categorizes issue or PR as related to a bug. label Mar 9, 2021
@k8s-ci-robot k8s-ci-robot added sig/network Categorizes an issue or PR as relevant to SIG Network. needs-triage Indicates an issue or PR lacks a `triage/foo` label and requires one. labels Mar 9, 2021
@robscott
Copy link
Member Author

robscott commented Mar 9, 2021

/triage accepted

@k8s-ci-robot k8s-ci-robot added triage/accepted Indicates an issue or PR is ready to be actively worked on. and removed needs-triage Indicates an issue or PR lacks a `triage/foo` label and requires one. labels Mar 9, 2021
@robscott robscott mentioned this issue Mar 9, 2021
Merged
@aojea
Copy link
Member

aojea commented Mar 9, 2021

/cc

@robscott robscott mentioned this issue Mar 9, 2021
Closed
@robscott
Copy link
Member Author

When this bug is fixed, we'll need to rollback #100027.

@aojea
Copy link
Member

aojea commented Mar 10, 2021

When this bug is fixed, we'll need to rollback #100027.

just amend it in the PR that fix the bug, so we merge all together

@robscott robscott mentioned this issue Mar 10, 2021
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@robscott robscott

Labels
kind/bug Categorizes issue or PR as related to a bug. sig/network Categorizes an issue or PR as relevant to SIG Network. triage/accepted Indicates an issue or PR is ready to be actively worked on.
Projects
None yet
Milestone
No milestone
3 participants
@robscott @aojea @k8s-ci-robot