Add Endpoint Slice API Test

[swetharepakula]

What type of PR is this?

/kind feature

What this PR does / why we need it:

This PR adds a E2E test that tests all the EndpointSlice APIs.

Does this PR introduce a user-facing change?

NONE

Additional documentation e.g., KEPs (Kubernetes Enhancement Proposals), usage docs, etc.:

KEP: EndpointSlice KEP
Enhancement Issue: kubernetes/enhancements#752

/cc @aojea @andrewsykim @thockin @robscott @wojtek-t
/assign @liggitt
/sig network
/sig testing
/priority important-soon

[k8s-ci-robot]

@swetharepakula: GitHub didn't allow me to assign the following users: liggit.

Note that only kubernetes members, repo collaborators and people who have commented on this issue/PR can be assigned. Additionally, issues/PRs can only have 10 assignees at the same time.
For more information please see the contributor guide

In response to this:

What type of PR is this?

/kind feature

What this PR does / why we need it:

This PR adds a E2E test that tests all the EndpointSlice APIs.

Does this PR introduce a user-facing change?

NONE

Additional documentation e.g., KEPs (Kubernetes Enhancement Proposals), usage docs, etc.:

KEP: EndpointSlice KEP
Enhancement Issue: kubernetes/enhancements#752

/cc @aojea @andrewsykim @thockin @robscott @wojtek-t
/assign @LiGgit
/sig network
/sig testing
/priority important-soon

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

[k8s-ci-robot]

@swetharepakula: This issue is currently awaiting triage.

If a SIG or subproject determines this is a relevant issue, they will accept it by applying the triage/accepted label and provide further guidance.

The triage/accepted label can be added by org members by writing /triage accepted in a comment.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

[k8s-ci-robot]

Hi @swetharepakula. Thanks for your PR.

I'm waiting for a kubernetes member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

[robscott]

Thanks!

/ok-to-test

[robscott]

/cc @Riaankl @hh

[robscott]

Thanks!

/lgtm

[swetharepakula]

/assign @thockin

[thockin]

/approve

[k8s-ci-robot]

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: swetharepakula, thockin

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

• test/e2e/network/OWNERS [thockin]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

[palnabarun]

Since the PR was lgtm'ed and approved before the Code Freeze was in effect and is just blocked on Prow, I am adding it to the milestone.

/milestone v1.21

[Riaankl]

Thank you @swetharepakula for this e2e tests.
In the update of APISnoop it can be seen that 3 additional endpoints are tested.
https://apisnoop.cncf.io/1.21.0/stable/discovery

[robscott]

@Riaankl do you know why that seems to conflict with what was actually added by this test? This test seems to pretty clearly include patch, read, and delete calls. I think we may still be missing replace, but it doesn't seem like we should be missing all of those with this PR in.

[Riaankl]

@robscott I do not see any obvious reason why the endpoints do not show up in the logs. And I have little knowledge about Network endpoints.
/cc @johnbelamaric

[johnbelamaric]

all namespace list and watch should be there too. it's very odd. It would seem to be an apisnoop reporting issue - we should double check the logs and see

[Riaankl]

all namespace list and watch should be there too. it's very odd. It would seem to be an apisnoop reporting issue - we should double check the logs and see

Thank you for the quick review @johnbelamaric
We will check the log information in APISnoop to see if something shows up there.

[swetharepakula]

Just verified that all the endpoints are being tracked now. Thanks @Riaankl & @johnbelamaric !
https://apisnoop.cncf.io/1.21.0/stable/discovery

[Riaankl]

@swetharepakula @robscott
50% is only e2e tested and 50% conformance tested. All should be conformance tested,
We are busy looking at how APISnoop is consuming the data created by these endpoints in the audit logs.
If more action is needed around the tests/promotion I will get back to you.

[swetharepakula]

This PR added coverage for some of the endpoints. We are waiting for the 2 week soak policy to promote to conformance.

[Riaankl]

@swetharepakula I can not find the EndpointSlice tests on the test grid.
When are the 2 weeks over for this test?
Please keep in mind that the 1.21 test freeze is on 23 March. It is a requirement that all new GA endpoints must have Conformance tests in the same release that the endpoints graduate.

[Riaankl]

all namespace list and watch should be there too. it's very odd. It would seem to be an apisnoop reporting issue - we should double check the logs and see

Thank you for the quick review @johnbelamaric
We will check the log information in APISnoop to see if something shows up there.

@johnbelamaric Thank you for your advice, it turned out to be the way APISnoop consumes these specific endpoints logs.
It now shows up correctly in the logs and the UI.

[swetharepakula]

@Riaankl I am not exactly sure what the difference in the links are but this testgrid link shows the tests: https://testgrid.k8s.io/sig-release-master-blocking#gce-cos-master-default&include-filter-by-regex=EndpointSlice&width=5.

The test started running 3/10/2021 , so it will qualify for conformance on the 24th.

One clarification, is the test freeze on March 23 or March 24th? The release docs say March 24.

[Riaankl]

@swetharepakula testgrid is looking good. (got my link wrong)
Yes, 24th is correct, I normally try and close all open points a day before.
Thank you for the GREAT work.
Looking forward to the Promotion.