Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

EndpointSlice API #752

Open
freehan opened this issue Jan 29, 2019 · 128 comments
Open

EndpointSlice API #752

freehan opened this issue Jan 29, 2019 · 128 comments

Comments

@freehan
Copy link
Member

@freehan freehan commented Jan 29, 2019

Enhancement Description

  • One-line enhancement description (can be used as a release note): New Endpoint API as eventual replacement of the current core/v1 Endpoints API.
  • Primary contact (assignee): @freehan
  • Responsible SIGs: sig-network, sig-scalability
  • Kubernetes Enhancement Proposal PR: #1086
  • Kubernetes Enhancement Proposal:https://github.com/kubernetes/enhancements/tree/master/keps/sig-network/0752-endpointslices
  • Link to e2e and/or unit tests: TBD
  • Reviewer(s) - (for LGTM) recommend having 2+ reviewers (at least one from code-area OWNERS file) agreed to review. Reviewers from multiple companies preferred: @thockin @wojtek-t
  • Approver (likely from SIG/area to which enhancement belongs): @thockin @wojtek-t
  • Enhancement target (which target equals to which milestone):
    • Alpha release target (1.15)
    • Beta release target (1.16)
    • Stable release target (1.17)
@liggitt
Copy link
Member

@liggitt liggitt commented Jan 31, 2019

was this intended to be targeted at 1.14 or 1.15?

@liggitt
Copy link
Member

@liggitt liggitt commented Jan 31, 2019

moving to 1.15, since there's no design in progress yet
/milestone v1.15

@k8s-ci-robot
Copy link
Contributor

@k8s-ci-robot k8s-ci-robot commented Jan 31, 2019

@liggitt: The provided milestone is not valid for this repository. Milestones in this repository: [keps-beta, keps-ga, v1.13, v1.14]

Use /milestone clear to clear the milestone.

In response to this:

moving to 1.15, since there's no design in progress yet
/milestone v1.15

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@liggitt liggitt removed this from the v1.14 milestone Jan 31, 2019
@liggitt liggitt added this to the v1.15 milestone Jan 31, 2019
@wojtek-t
Copy link
Member

@wojtek-t wojtek-t commented Jan 31, 2019

We would like to have the KEP approved in 1.14 timeframe, so that we would be able to reach alpha in 1.15.

@liggitt
Copy link
Member

@liggitt liggitt commented Jan 31, 2019

sounds good; that means the actual changes are targeting 1.15, so I think the 1.15 milestone is accurate

@wojtek-t
Copy link
Member

@wojtek-t wojtek-t commented Jan 31, 2019

Agree.

@kacole2
Copy link
Member

@kacole2 kacole2 commented Apr 11, 2019

Hello @wojtek-t @freehan, I'm the Enhancement Lead for 1.15. Is this feature going to be targeting alpha in 1.15? I do not see a KEP which is required. Please let me know so it can be tracked properly and added to the spreadsheet.

Once coding begins, please list all relevant k/k PRs in this issue so they can be tracked properly.

@wojtek-t
Copy link
Member

@wojtek-t wojtek-t commented Apr 16, 2019

Yes - we're targetting 1.15 for Alpha release. Will keep it issue updated.

@mrbobbytables
Copy link
Member

@mrbobbytables mrbobbytables commented Apr 29, 2019

@freehan, @wojtek-t Kubernetes 1.15 Enhancement Freeze is 4/30/2019. To be included in the Kubernetes 1.15 milestone, KEPs are required to be merged and in an "Implementable" state with proper test plans and graduation criteria. Please submit any PRs needed to make this KEP adhere to inclusion criteria. If this will slip from the 1.15 milestone, please let us know so we can make appropriate tracking changes.

@freehan
Copy link
Member Author

@freehan freehan commented Apr 30, 2019

The proposal is already out. It has been shared with the community and still in discussion. KEP is not merged yet.

https://docs.google.com/document/d/1sLJfolOeEVzK5oOviRmtHOHmke8qtteljQPaDUEukxY/edit#heading=h.3v0n1vmx9wtr

@mrbobbytables
Copy link
Member

@mrbobbytables mrbobbytables commented May 1, 2019

@freehan @wojtek-t The Enhancement Freeze for Kubernetes 1.15 has passed and this did not meet the deadline. This is now being removed from the 1.15 milestone and the tracking sheet. If there is a need for this to be in 1.15, please file an Enhancement Exception. Thank you.

@kacole2
Copy link
Member

@kacole2 kacole2 commented Jul 9, 2019

Hi @freehan @wojtek-t , I'm the 1.16 Enhancement Lead. Is this feature going to be graduating alpha/beta/stable stages in 1.16? Please let me know so it can be added to the 1.16 Tracking Spreadsheet. If not's graduating, I will remove it from the milestone and change the tracked label.

Once coding begins or if it already has, please list all relevant k/k PRs in this issue so they can be tracked properly.

Milestone dates are Enhancement Freeze 7/30 and Code Freeze 8/29.

Thank you.

@freehan
Copy link
Member Author

@freehan freehan commented Jul 9, 2019

@kacole2 I do not have permission to add it into spreadsheet. Would you mind adding me to it?

KEP in flight: #1086

@kacole2 kacole2 added this to the v1.16 milestone Jul 9, 2019
@annajung
Copy link
Member

@annajung annajung commented Apr 9, 2021

thanks @swetharepakula @robscott for the clarification, please ignore my previous message! thanks :)

@aojea aojea moved this from In progress to GA in SIG-Network KEPs Apr 17, 2021
@JamesLaverack
Copy link
Member

@JamesLaverack JamesLaverack commented May 1, 2021

/milestone v1.22

@k8s-ci-robot k8s-ci-robot removed this from the v1.21 milestone May 1, 2021
@k8s-ci-robot k8s-ci-robot added this to the v1.22 milestone May 1, 2021
@reylejano
Copy link
Member

@reylejano reylejano commented May 10, 2021

Hi @swetharepakula,

1.22 Enhancement shadow checking in. The Enhancement freeze is coming up at 23:59:59 PST on Thursday 13th May. In reviewing your KEP, one item needs attention before the freeze:

  • In the kep.yaml , update the current-milestone and stable to "v1.22"

If you have any questions, please reach out.

@swetharepakula
Copy link
Member

@swetharepakula swetharepakula commented May 10, 2021

The current-milestone will be updated as part of #2673

@reylejano
Copy link
Member

@reylejano reylejano commented May 11, 2021

Hi @swetharepakula ,

With PR 2673 , this enhancement is all set for the 1.22 Enhancements Freeze 🎉

@swetharepakula
Copy link
Member

@swetharepakula swetharepakula commented May 11, 2021

/assign @swetharepakula

@ritpanjw
Copy link

@ritpanjw ritpanjw commented May 19, 2021

Hello @swetharepakula 👋 , 1.22 Docs Shadow here.

This enhancement is marked as Needs Docs for 1.22 release.
Please follow the steps detailed in the documentation to open a PR against dev-1.22 branch in the k/website repo. This PR can be just a placeholder at this time and must be created before Fri July 9, 11:59 PM PDT.
Also, take a look at Documenting for a release to familiarize yourself with the docs requirement for the release.

Thank you!

@thockin thockin moved this from GA (merged, gate not removed) to Beta (merged) in SIG-Network KEPs May 22, 2021
@reylejano
Copy link
Member

@reylejano reylejano commented Jun 21, 2021

Hi @swetharepakula ,
Are there any code changes planned for the 1.22 release?

@swetharepakula
Copy link
Member

@swetharepakula swetharepakula commented Jun 21, 2021

Hi @reylejano 👋 ,

There are some code changes that are planned for this release (most likely will span over a couple PRs). I have not yet submitted them yet, but will make sure to link them to this issue when I submit.

@reylejano
Copy link
Member

@reylejano reylejano commented Jul 1, 2021

Hi @swetharepakula ,

I see that kubernetes/kubernetes#103306 was linked and is merged.
Are there any additional k/k PRs required for 1.22 before code freeze on July 8, 2021?

Also a reminder that the Docs Placeholder PR deadline is on July 9, 2021.
Here are instructions on opening a PR against the dev-1.22 branch in the k/website repo

@swetharepakula
Copy link
Member

@swetharepakula swetharepakula commented Jul 2, 2021

Hi @reylejano,

I am hoping to get 2 more PRs in. They are both WIPs at this moment. However, kubernetes/kubernetes#103306 was the most crucial one.

I have opened up the draft docs PR: kubernetes/website#28745

@reylejano
Copy link
Member

@reylejano reylejano commented Jul 6, 2021

Hi @swetharepakula ,

Just a reminder that the 1.22 code freeze starts in a few days on Thursday, July 8 at 18:00 PDT. The following PR and any other PR required for this enhancement for 1.22 has to merge by then:

This enhancement is currently at-risk of falling out of 1.22 with kubernetes/kubernetes#103451 open

@swetharepakula
Copy link
Member

@swetharepakula swetharepakula commented Jul 6, 2021

kubernetes/kubernetes#103451 & kubernetes/kubernetes#103520 need to be merged for close out this kep.

The higher priority is kubernetes/kubernetes#103451.

@swetharepakula
Copy link
Member

@swetharepakula swetharepakula commented Jul 7, 2021

Both kubernetes/kubernetes#103451 & kubernetes/kubernetes#103520 have been approved. We are just waiting on merging for both

@swetharepakula
Copy link
Member

@swetharepakula swetharepakula commented Jul 8, 2021

All PRs for this KEP have been merged.

@reylejano
Copy link
Member

@reylejano reylejano commented Jul 8, 2021

Hi @swetharepakula ,

With the following PRs merged, this enhancement is set for the 1.22 code freeze 🎉

@thockin thockin moved this from Beta gated (merged) to GA (merged, gate not removed) in SIG-Network KEPs Jul 8, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
SIG-Network KEPs
GA (merged, gate not removed)
Linked pull requests

Successfully merging a pull request may close this issue.

None yet