Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

sig-testing: support auto-tag and auto-bump for test images #100273

Open
chewong opened this issue Mar 16, 2021 · 14 comments
Open

sig-testing: support auto-tag and auto-bump for test images #100273

chewong opened this issue Mar 16, 2021 · 14 comments
Labels
lifecycle/frozen Indicates that an issue or PR should not be auto-closed due to staleness. needs-triage Indicates an issue or PR lacks a `triage/foo` label and requires one. sig/testing Categorizes an issue or PR as relevant to SIG Testing.

Comments

@chewong
Copy link
Member

chewong commented Mar 16, 2021

I forget how this works but technically we can't use 2.30 until it's been promoted. Usually there's a followup PR that updates test/images/manifest once promotion has occurred. Is that the more appropriate PR to make this change?

The two-step image promotion dance and fixed/hardcoded version approach used by e2e test images could really stand to be revisited. Not suggesting we try to do it in v1.21 just more thinking out loud. Auto-tagging with date+gitsha is an approach that's worked well for other images in this project AFAIK.

Originally posted by @spiffxp in #99860 (comment)

@chewong
Copy link
Member Author

chewong commented Mar 16, 2021

/sig testing

@k8s-ci-robot k8s-ci-robot added sig/testing Categorizes an issue or PR as relevant to SIG Testing. needs-triage Indicates an issue or PR lacks a `triage/foo` label and requires one. labels Mar 16, 2021
@BenTheElder
Copy link
Member

I think auto tag is a good idea. I don't think we're ready for auto-promote yet which would block automatically using new tags.

@BenTheElder
Copy link
Member

This should probably be brought up somewhere with more visibility to see if anyone has concerns with date-sha, but otherwise I think this is
/triage accepted

@k8s-ci-robot k8s-ci-robot added triage/accepted Indicates an issue or PR is ready to be actively worked on. and removed needs-triage Indicates an issue or PR lacks a `triage/foo` label and requires one. labels May 15, 2021
@BenTheElder
Copy link
Member

raised in #sig-testing slack to see if anyone else has input

@spiffxp
Copy link
Member

spiffxp commented Jul 27, 2021

/milestone v1.23
I think this worth considering now that we've consolidated most images to staging repos

@k8s-ci-robot k8s-ci-robot added this to the v1.23 milestone Jul 27, 2021
@k8s-triage-robot
Copy link

The Kubernetes project currently lacks enough contributors to adequately respond to all issues and PRs.

This bot triages issues and PRs according to the following rules:

  • After 90d of inactivity, lifecycle/stale is applied
  • After 30d of inactivity since lifecycle/stale was applied, lifecycle/rotten is applied
  • After 30d of inactivity since lifecycle/rotten was applied, the issue is closed

You can:

  • Mark this issue or PR as fresh with /remove-lifecycle stale
  • Mark this issue or PR as rotten with /lifecycle rotten
  • Close this issue or PR with /close
  • Offer to help out with Issue Triage

Please send feedback to sig-contributor-experience at kubernetes/community.

/lifecycle stale

@k8s-ci-robot k8s-ci-robot added the lifecycle/stale Denotes an issue or PR has remained open with no activity and has become stale. label Oct 25, 2021
@NilimaC04
Copy link

Hi 👋 I'm the bug triage shadow for release 1.23.
There hasn't been any activity on this issue for a couple of months now. Just want to make sure this issue is still on track for the 1.23?

@BenTheElder
Copy link
Member

I don't think this is happening in 1.23 at least. I'm not aware of anyone taking this up.
/milestone clear

@k8s-ci-robot k8s-ci-robot removed this from the v1.23 milestone Nov 8, 2021
@NilimaC04
Copy link

Thanks for the update @BenTheElder! Can we plan to do this in v1.24?

@BenTheElder
Copy link
Member

I don't know of anyone planning to work on this currently, so I don't think we can plan on any particular milestone.

@k8s-triage-robot
Copy link

The Kubernetes project currently lacks enough active contributors to adequately respond to all issues and PRs.

This bot triages issues and PRs according to the following rules:

  • After 90d of inactivity, lifecycle/stale is applied
  • After 30d of inactivity since lifecycle/stale was applied, lifecycle/rotten is applied
  • After 30d of inactivity since lifecycle/rotten was applied, the issue is closed

You can:

  • Mark this issue or PR as fresh with /remove-lifecycle rotten
  • Close this issue or PR with /close
  • Offer to help out with Issue Triage

Please send feedback to sig-contributor-experience at kubernetes/community.

/lifecycle rotten

@k8s-ci-robot k8s-ci-robot added lifecycle/rotten Denotes an issue or PR that has aged beyond stale and will be auto-closed. and removed lifecycle/stale Denotes an issue or PR has remained open with no activity and has become stale. labels Dec 11, 2021
@BenTheElder
Copy link
Member

/lifecycle frozen

@k8s-ci-robot k8s-ci-robot added lifecycle/frozen Indicates that an issue or PR should not be auto-closed due to staleness. and removed lifecycle/rotten Denotes an issue or PR that has aged beyond stale and will be auto-closed. labels Jan 7, 2022
@k8s-triage-robot
Copy link

This issue has not been updated in over 1 year, and should be re-triaged.

You can:

  • Confirm that this issue is still relevant with /triage accepted (org members only)
  • Close this issue with /close

For more details on the triage process, see https://www.kubernetes.dev/docs/guide/issue-triage/

/remove-triage accepted

@k8s-ci-robot k8s-ci-robot added needs-triage Indicates an issue or PR lacks a `triage/foo` label and requires one. and removed triage/accepted Indicates an issue or PR is ready to be actively worked on. labels Feb 8, 2023
@k8s-ci-robot
Copy link
Contributor

This issue is currently awaiting triage.

If a SIG or subproject determines this is a relevant issue, they will accept it by applying the triage/accepted label and provide further guidance.

The triage/accepted label can be added by org members by writing /triage accepted in a comment.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
lifecycle/frozen Indicates that an issue or PR should not be auto-closed due to staleness. needs-triage Indicates an issue or PR lacks a `triage/foo` label and requires one. sig/testing Categorizes an issue or PR as relevant to SIG Testing.
Projects
None yet
Development

No branches or pull requests

6 participants