New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Promote EndpointSlice API test to Conformance #100418
Promote EndpointSlice API test to Conformance #100418
Conversation
Thanks! /lgtm |
/triage accepted |
@dims Please add to milestone 1.21 Thank you @swetharepakula |
/milestone v1.21 |
I'm satisfied. |
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: johnbelamaric, swetharepakula The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
/test pull-kubernetes-e2e-kind-ipv6
|
/test pull-kubernetes-e2e-kind
|
Changes in coverage diff Mon Mar 22 22:41:35 UTC 2021 PR for EndpointsSlice merged kubernetes/kubernetes/pull/100418 No new endpoints without conformance tests in 1.21!!
APISnoop was updated and all EndpointSlice endpoint now have Conformance tests. |
What type of PR is this?
/kind feature
What this PR does / why we need it:
This PR promotes the last EndpointPoint Slice API e2e test to conformance.
Special notes for your reviewer:
This e2e test was introduced into testgrid on 3/10: https://testgrid.k8s.io/sig-release-master-blocking#gce-cos-master-default&include-filter-by-regex=EndpointSlice&width=5 and has been flake free. It will qualify on 3/24 and this PR can be merged then.
This will add the remaining coverage needed for the v1 EndpointSlice APIs:
https://apisnoop.cncf.io/1.21.0/stable/discovery
Does this PR introduce a user-facing change?
Additional documentation e.g., KEPs (Kubernetes Enhancement Proposals), usage docs, etc.:
KEP: EndpointSlice KEP
Enhancement Issue: kubernetes/enhancements#752
/sig network
/sig testing
/cc @Riaankl @hh @robscott @aojea
/assign @thockin