Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Promote EndpointSlice API test to Conformance #100418

Merged
merged 1 commit into from Mar 22, 2021

Conversation

swetharepakula
Copy link
Member

What type of PR is this?

/kind feature

What this PR does / why we need it:

This PR promotes the last EndpointPoint Slice API e2e test to conformance.

Special notes for your reviewer:

This e2e test was introduced into testgrid on 3/10: https://testgrid.k8s.io/sig-release-master-blocking#gce-cos-master-default&include-filter-by-regex=EndpointSlice&width=5 and has been flake free. It will qualify on 3/24 and this PR can be merged then.

This will add the remaining coverage needed for the v1 EndpointSlice APIs:
https://apisnoop.cncf.io/1.21.0/stable/discovery

Screen Shot 2021-03-19 at 4 38 42 PM

Does this PR introduce a user-facing change?

NONE

Additional documentation e.g., KEPs (Kubernetes Enhancement Proposals), usage docs, etc.:

KEP: EndpointSlice KEP
Enhancement Issue: kubernetes/enhancements#752

/sig network
/sig testing
/cc @Riaankl @hh @robscott @aojea
/assign @thockin

@k8s-ci-robot k8s-ci-robot added the release-note-none Denotes a PR that doesn't merit a release note. label Mar 19, 2021
@k8s-ci-robot k8s-ci-robot added kind/feature Categorizes issue or PR as related to a new feature. size/S Denotes a PR that changes 10-29 lines, ignoring generated files. sig/network Categorizes an issue or PR as relevant to SIG Network. sig/testing Categorizes an issue or PR as relevant to SIG Testing. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. needs-triage Indicates an issue or PR lacks a `triage/foo` label and requires one. needs-priority Indicates a PR lacks a `priority/foo` label and requires one. area/conformance Issues or PRs related to kubernetes conformance tests area/test sig/architecture Categorizes an issue or PR as relevant to SIG Architecture. labels Mar 19, 2021
@robscott
Copy link
Member

Thanks!

/lgtm
/cc @johnbelamaric

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Mar 19, 2021
@Riaankl
Copy link
Contributor

Riaankl commented Mar 21, 2021

/triage accepted

@k8s-ci-robot k8s-ci-robot added triage/accepted Indicates an issue or PR is ready to be actively worked on. and removed needs-triage Indicates an issue or PR lacks a `triage/foo` label and requires one. labels Mar 21, 2021
@Riaankl
Copy link
Contributor

Riaankl commented Mar 21, 2021

@dims Please add to milestone 1.21
This promotion address endpoints graduated to GA in 1.21 but still do not have conformance tests.

Thank you @swetharepakula

@Riaankl Riaankl added this to Promotion PRs Needing Approval in conformance-definition Mar 21, 2021
@dims
Copy link
Member

dims commented Mar 21, 2021

/milestone v1.21

@k8s-ci-robot k8s-ci-robot added this to the v1.21 milestone Mar 21, 2021
@johnbelamaric
Copy link
Member

I'm satisfied.
/lgtm
/approve

@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: johnbelamaric, swetharepakula

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Mar 22, 2021
@Riaankl
Copy link
Contributor

Riaankl commented Mar 22, 2021

/test pull-kubernetes-e2e-kind-ipv6
Unrelated flake

• Failure [55.787 seconds]
[sig-node] Probing container
/home/prow/go/src/k8s.io/kubernetes/_output/local/go/src/k8s.io/kubernetes/test/e2e/common/node/framework.go:23
  should be ready immediately after startupProbe succeeds [It]
  /home/prow/go/src/k8s.io/kubernetes/_output/local/go/src/k8s.io/kubernetes/test/e2e/common/node/container_probe.go:380
skipped 19431 lines unfold_more
[Fail] [sig-node] Probing container [It] should be ready immediately after startupProbe succeeds 
/home/prow/go/src/k8s.io/kubernetes/_output/local/go/src/k8s.io/kubernetes/vendor/github.com/onsi/ginkgo/internal/leafnodes/runner.go:113

@Riaankl
Copy link
Contributor

Riaankl commented Mar 22, 2021

/test pull-kubernetes-e2e-kind
Unrelated flake

Kubernetes e2e suite: [sig-node] InitContainer [NodeConformance] should not start app containers if init containers fail on a RestartAlways pod [Conformance] expand_less | 5m3s
-- | --
/home/prow/go/src/k8s.io/kubernetes/_output/local/go/src/k8s.io/kubernetes/test/e2e/framework/framework.go:630 Mar 22 19:29:17.017: Unexpected error:     <*errors.errorString \| 0xc00024a250>: {         s: "timed out waiting for the condition",     }     timed out waiting for the condition occurred /home/prow/go/src/k8s.io/kubernetes/_output/local/go/src/k8s.io/kubernetes/test/e2e/common/node/init_container.go:432

@k8s-ci-robot k8s-ci-robot merged commit 1a983bb into kubernetes:master Mar 22, 2021
conformance-definition automation moved this from Promotion PRs Needing Approval to Done Mar 22, 2021
Riaankl added a commit to kubernetes-sigs/apisnoop that referenced this pull request Mar 22, 2021
Changes in coverage diff Mon Mar 22 22:41:35 UTC 2021
PR for EndpointsSlice merged kubernetes/kubernetes/pull/100418
No new endpoints without conformance tests in 1.21!!
@Riaankl
Copy link
Contributor

Riaankl commented Mar 22, 2021

APISnoop was updated and all EndpointSlice endpoint now have Conformance tests.
https://apisnoop.cncf.io/1.21.0/stable/discovery
image

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. area/conformance Issues or PRs related to kubernetes conformance tests area/test cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. kind/feature Categorizes issue or PR as related to a new feature. lgtm "Looks good to me", indicates that a PR is ready to be merged. needs-priority Indicates a PR lacks a `priority/foo` label and requires one. release-note-none Denotes a PR that doesn't merit a release note. sig/architecture Categorizes an issue or PR as relevant to SIG Architecture. sig/network Categorizes an issue or PR as relevant to SIG Network. sig/testing Categorizes an issue or PR as relevant to SIG Testing. size/S Denotes a PR that changes 10-29 lines, ignoring generated files. triage/accepted Indicates an issue or PR is ready to be actively worked on.
Projects
Development

Successfully merging this pull request may close these issues.

None yet

7 participants