Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

improve the readability of log #100874

Merged
merged 1 commit into from
Apr 11, 2021
Merged

Conversation

lojies
Copy link
Contributor

@lojies lojies commented Apr 7, 2021

What type of PR is this?

/kind cleanup

What this PR does / why we need it:

Improve the readability of kube-proxy log.

before change:

I0407 14:16:29.804691   19372 proxier.go:1609] "Restoring iptables" rules=[42 102 105 108 116 101 114 10 58 75 85 66 69 45 83 69 82 86 73 67 69 83 32 45 32 91 48 58 48 93 10 58 75 85 66 69 45 69 88 84 69 82 78 65 76 45 83 69 82 86 73 67 69 83 32 45 32 91 48 58 48 93 10 58 75 85 66 69 45 70 79 82 87 65 82 68 32 45 32 91 48 58 48 93 10 58 75 85 66 69 45 78 79 68 69 80 79 82 84 83 32 45 32 91 48 58 48 93 10 45 65 32 75 85 66 69 45 83 69 82 86 73 67 69 83 32 45 109 32 99 111 109 109 101 110 116 32 45 45 99 111 109 109 101 110 116 32 34 104 105 118 101 115 101 99 47 99 108 117 115 116 101 114 45 108 105 110 107 58 112 114 111 120 121 32 104 97 115 32 110 111 32 101 110 100 112 111 105 110 116 115 34 32 45 109 32 116 99 112 32 45 112 32 116 99 112 32 45 100 32 49 48 46 50 53 52 46 50 48 48 46 49 48 54 47 51 50 32 45 45 100 112 111 114 116 32 49 48 56 48 32 45 106 32 82 69 74 69 67 84 10 45 65 32 75 85 66 69 45 83 69 82 86 73 67 69 83 32 45 109 32 99 111 109 109 101 110 116 32 45 45 99 111 109 109 101 110 116 32 34 100 101 102 97 117 108 116 47 107 117 98 101 114 110 101 116 101 115 58 104 116 116 112 115 32 104 97 115 32 110 111 32 101 110 100 112 111 105 110 116 115 34 32 45 109 32 116 99 112 32 45 112 32 116 99 112 32 45 100 32 49 48 46 50 53 52 46 48 46 49 47 51 50 32 45 45 100 112 111 114 116 32 52 52 51 32 45 106 32 82 69 74 69 67 84 10 45 65 32 75 85 66 69 45 83 69 82 86 73 67 69 83 32 45 109 32 99 111 109 109 101 110 116 32 45 45 99 111 109 109 101 110 116 32 34 104 105 118 101 115 101 99 47 99 108 117 115 116 101 114 45 108 105 110 107 58 99 108 117 115 116 101 114 45 108 105 110 107 32 104 97 115 32 110 111 32 101 110 100 112 111 105 110 116 115 34 32 45 109 32 116 99 112 32 45 112 32 116 99 112 32 45 100 32 49 48 46 50 53 52 46 50 48 48 46 49 48 54 47 51 50 32 45 45 100 112 111 114 116 32 57 48 48 49 32 45 106 32 82 69 74 69 67 84 10 45 65 32 75 85 66 69 45 70 79 82 87 65 82 68 32 45 109 32 99 111 110 110 116 114 97 99 107 32 45 45 99 116 115 116 97 116 101 32 73 78 86 65 76 73 68 32 45 106 32 68 82 79 80 10 45 65 32 75 85 66 69 45 70 79 82 87 65 82 68 32 45 109 32 99 111 109 109 101 110 116 32 45 45 99 111 109 109 101 110 116 32 34 107 117 98 101 114 110 101 116 101 115 32 102 111 114 119 97 114 100 105 110 103 32 114 117 108 101 115 34 32 45 109 32 109 97 114 107 32 45 45 109 97 114 107 32 48 120 48 48 48 48 52 48 48 48 47 48 120 48 48 48 48 52 48 48 48 32 45 106 32 65 67 67 69 80 84 10 45 65 32 75 85 66 69 45 70 79 82 87 65 82 68 32 45 109 32 99 111 109 109 101 110 116 32 45 45 99 111 109 109 101 110 116 32 34 107 117 98 101 114 110 101 116 101 115 32 102 111 114 119 97 114 100 105 110 103 32 99 111 110 110 116 114 97 99 107 32 112 111 100 32 115 111 117 114 99 101 32 114 117 108 101 34 32 45 109 32 99 111 110 110 116 114 97 99 107 32 45 45 99 116 115 116 97 116 101 32 82 69 76 65 84 69 68 44 69 83 84 65 66 76 73 83 72 69 68 32 45 106 32 65 67 67 69 80 84 10 45 65 32 75 85 66 69 45 70 79 82 87 65 82 68 32 45 109 32 99 111 109 109 101 110 116 32 45 45 99 111 109 109 101 110 116 32 34 107 117 98 101 114 110 101 116 101 115 32 102 111 114 119 97 114 100 105 110 103 32 99 111 110 110 116 114 97 99 107 32 112 111 100 32 100 101 115 116 105 110 97 116 105 111 110 32 114 117 108 101 34 32 45 109 32 99 111 110 110 116 114 97 99 107 32 45 45 99 116 115 116 97 116 101 32 82 69 76 65 84 69 68 44 69 83 84 65 66 76 73 83 72 69 68 32 45 106 32 65 67 67 69 80 84 10 67 79 77 77 73 84 10 42 110 97 116 10 58 75 85 66 69 45 83 69 82 86 73 67 69 83 32 45 32 91 48 58 48 93 10 58 75 85 66 69 45 78 79 68 69 80 79 82 84 83 32 45 32 91 48 58 48 93 10 58 75 85 66 69 45 80 79 83 84 82 79 85 84 73 78 71 32 45 32 91 48 58 48 93 10 58 75 85 66 69 45 77 65 82 75 45 77 65 83 81 32 45 32 91 48 58 48 93 10 45 65 32 75 85 66 69 45 80 79 83 84 82 79 85 84 73 78 71 32 45 109 32 109 97 114 107 32 33 32 45 45 109 97 114 107 32 48 120 48 48 48 48 52 48 48 48 47 48 120 48 48 48 48 52 48 48 48 32 45 106 32 82 69 84 85 82 78 10 45 65 32 75 85 66 69 45 80 79 83 84 82 79 85 84 73 78 71 32 45 106 32 77 65 82 75 32 45 45 120 111 114 45 109 97 114 107 32 48 120 48 48 48 48 52 48 48 48 10 45 65 32 75 85 66 69 45 80 79 83 84 82 79 85 84 73 78 71 32 45 109 32 99 111 109 109 101 110 116 32 45 45 99 111 109 109 101 110 116 32 34 107 117 98 101 114 110 101 116 101 115 32 115 101 114 118 105 99 101 32 116 114 97 102 102 105 99 32 114 101 113 117 105 114 105 110 103 32 83 78 65 84 34 32 45 106 32 77 65 83 81 85 69 82 65 68 69 10 45 65 32 75 85 66 69 45 77 65 82 75 45 77 65 83 81 32 45 106 32 77 65 82 75 32 45 45 111 114 45 109 97 114 107 32 48 120 48 48 48 48 52 48 48 48 10 45 65 32 75 85 66 69 45 83 69 82 86 73 67 69 83 32 45 109 32 99 111 109 109 101 110 116 32 45 45 99 111 109 109 101 110 116 32 34 107 117 98 101 114 110 101 116 101 115 32 115 101 114 118 105 99 101 32 110 111 100 101 112 111 114 116 115 59 32 78 79 84 69 58 32 116 104 105 115 32 109 117 115 116 32 98 101 32 116 104 101 32 108 97 115 116 32 114 117 108 101 32 105 110 32 116 104 105 115 32 99 104 97 105 110 34 32 45 109 32 97 100 100 114 116 121 112 101 32 45 45 100 115 116 45 116 121 112 101 32 76 79 67 65 76 32 45 106 32 75 85 66 69 45 78 79 68 69 80 79 82 84 83 10 67 79 77 77 73 84 10]

after change:

I0407 14:46:38.348661   24496 proxier.go:1609] "Restoring iptables" rules="*filter\n:KUBE-SERVICES - [0:0]\n:KUBE-EXTERNAL-SERVICES - [0:0]\n:KUBE-FORWARD - [0:0]\n:KUBE-NODEPORTS - [0:0]\n-A KUBE-SERVICES -m comment --comment \"default/kubernetes:https has no endpoints\" -m tcp -p tcp -d 10.254.0.1/32 --dport 443 -j REJECT\n-A KUBE-SERVICES -m comment --comment \"hivesec/cluster-link:cluster-link has no endpoints\" -m tcp -p tcp -d 10.254.200.106/32 --dport 9001 -j REJECT\n-A KUBE-SERVICES -m comment --comment \"hivesec/cluster-link:proxy has no endpoints\" -m tcp -p tcp -d 10.254.200.106/32 --dport 1080 -j REJECT\n-A KUBE-FORWARD -m conntrack --ctstate INVALID -j DROP\n-A KUBE-FORWARD -m comment --comment \"kubernetes forwarding rules\" -m mark --mark 0x00004000/0x00004000 -j ACCEPT\n-A KUBE-FORWARD -m comment --comment \"kubernetes forwarding conntrack pod source rule\" -m conntrack --ctstate RELATED,ESTABLISHED -j ACCEPT\n-A KUBE-FORWARD -m comment --comment \"kubernetes forwarding conntrack pod destination rule\" -m conntrack --ctstate RELATED,ESTABLISHED -j ACCEPT\nCOMMIT\n*nat\n:KUBE-SERVICES - [0:0]\n:KUBE-NODEPORTS - [0:0]\n:KUBE-POSTROUTING - [0:0]\n:KUBE-MARK-MASQ - [0:0]\n-A KUBE-POSTROUTING -m mark ! --mark 0x00004000/0x00004000 -j RETURN\n-A KUBE-POSTROUTING -j MARK --xor-mark 0x00004000\n-A KUBE-POSTROUTING -m comment --comment \"kubernetes service traffic requiring SNAT\" -j MASQUERADE\n-A KUBE-MARK-MASQ -j MARK --or-mark 0x00004000\n-A KUBE-SERVICES -m comment --comment \"kubernetes service nodeports; NOTE: this must be the last rule in this chain\" -m addrtype --dst-type LOCAL -j KUBE-NODEPORTS\nCOMMIT\n"

Which issue(s) this PR fixes:

Fixes #

Special notes for your reviewer:

Does this PR introduce a user-facing change?


Additional documentation e.g., KEPs (Kubernetes Enhancement Proposals), usage docs, etc.:


@k8s-ci-robot k8s-ci-robot added kind/cleanup Categorizes issue or PR as related to cleaning up code, process, or technical debt. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. do-not-merge/release-note-label-needed Indicates that a PR should not merge because it's missing one of the release note labels. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. do-not-merge/needs-sig Indicates an issue or PR lacks a `sig/foo` label and requires one. needs-triage Indicates an issue or PR lacks a `triage/foo` label and requires one. needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. needs-priority Indicates a PR lacks a `priority/foo` label and requires one. labels Apr 7, 2021
@k8s-ci-robot
Copy link
Contributor

Hi @lojies. Thanks for your PR.

I'm waiting for a kubernetes member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@k8s-ci-robot k8s-ci-robot added sig/network Categorizes an issue or PR as relevant to SIG Network. and removed do-not-merge/needs-sig Indicates an issue or PR lacks a `sig/foo` label and requires one. labels Apr 7, 2021
@yangjunmyfm192085
Copy link
Contributor

/release-note-none
/ok-to-test

@k8s-ci-robot k8s-ci-robot added release-note-none Denotes a PR that doesn't merit a release note. ok-to-test Indicates a non-member PR verified by an org member that is safe to test. and removed do-not-merge/release-note-label-needed Indicates that a PR should not merge because it's missing one of the release note labels. needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. labels Apr 7, 2021
@thockin
Copy link
Member

thockin commented Apr 7, 2021

Thanks!

/lgtm
/approve

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Apr 7, 2021
@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: lojies, thockin

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Apr 7, 2021
@yangjunmyfm192085
Copy link
Contributor

/retest

@yangjunmyfm192085
Copy link
Contributor

/triage accepted

@k8s-ci-robot k8s-ci-robot added triage/accepted Indicates an issue or PR is ready to be actively worked on. and removed needs-triage Indicates an issue or PR lacks a `triage/foo` label and requires one. labels Apr 8, 2021
@k8s-ci-robot k8s-ci-robot merged commit eda1de3 into kubernetes:master Apr 11, 2021
@k8s-ci-robot k8s-ci-robot added this to the v1.22 milestone Apr 11, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. kind/cleanup Categorizes issue or PR as related to cleaning up code, process, or technical debt. lgtm "Looks good to me", indicates that a PR is ready to be merged. needs-priority Indicates a PR lacks a `priority/foo` label and requires one. ok-to-test Indicates a non-member PR verified by an org member that is safe to test. release-note-none Denotes a PR that doesn't merit a release note. sig/network Categorizes an issue or PR as relevant to SIG Network. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. triage/accepted Indicates an issue or PR is ready to be actively worked on.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants