Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

code cleanup for kubectl #101004

Merged
merged 1 commit into from
Nov 3, 2021
Merged

code cleanup for kubectl #101004

merged 1 commit into from
Nov 3, 2021

Conversation

lojies
Copy link
Contributor

@lojies lojies commented Apr 12, 2021

What type of PR is this?

/kind cleanup

What this PR does / why we need it:

  1. remove unnecessary use of fmt.Sprintf
  2. remove repeated package import
k8s.io/kubernetes/staging/src/k8s.io/kubectl/pkg/cmd/autoscale/autoscale.go:126:57: unnecessary use of fmt.Sprintf (S1039)
k8s.io/kubernetes/staging/src/k8s.io/kubectl/pkg/cmd/certificates/certificates.go:29:2: package "k8s.io/apimachinery/pkg/api/errors" is being imported more than once (ST1019)
k8s.io/kubernetes/staging/src/k8s.io/kubectl/pkg/cmd/certificates/certificates.go:30:2: other import of "k8s.io/apimachinery/pkg/api/errors"
k8s.io/kubernetes/staging/src/k8s.io/kubectl/pkg/cmd/create/create_ingress.go:288:2: should merge variable declaration with assignment on next line (S1021)
k8s.io/kubernetes/staging/src/k8s.io/kubectl/pkg/cmd/create/create_ingress.go:317:2: should merge variable declaration with assignment on next line (S1021)
k8s.io/kubernetes/staging/src/k8s.io/kubectl/pkg/cmd/create/create_ingress_test.go:22:2: package "k8s.io/api/networking/v1" is being imported more than once (ST1019)
k8s.io/kubernetes/staging/src/k8s.io/kubectl/pkg/cmd/create/create_ingress_test.go:23:2: other import of "k8s.io/api/networking/v1"
k8s.io/kubernetes/staging/src/k8s.io/kubectl/pkg/cmd/debug/debug_test.go:28:2: package "k8s.io/api/core/v1" is being imported more than once (ST1019)
k8s.io/kubernetes/staging/src/k8s.io/kubectl/pkg/cmd/debug/debug_test.go:29:2: other import of "k8s.io/api/core/v1"
k8s.io/kubernetes/staging/src/k8s.io/kubectl/pkg/cmd/get/get_test.go:21:2: package "encoding/json" is being imported more than once (ST1019)
k8s.io/kubernetes/staging/src/k8s.io/kubectl/pkg/cmd/get/get_test.go:22:2: other import of "encoding/json"
k8s.io/kubernetes/staging/src/k8s.io/kubectl/pkg/describe/describe.go:55:2: package "k8s.io/apimachinery/pkg/api/errors" is being imported more than once (ST1019)
k8s.io/kubernetes/staging/src/k8s.io/kubectl/pkg/describe/describe.go:56:2: other import of "k8s.io/apimachinery/pkg/api/errors"

Which issue(s) this PR fixes:

Fixes #

Special notes for your reviewer:

Does this PR introduce a user-facing change?

NONE

Additional documentation e.g., KEPs (Kubernetes Enhancement Proposals), usage docs, etc.:

@k8s-ci-robot k8s-ci-robot added release-note-none Denotes a PR that doesn't merit a release note. kind/cleanup Categorizes issue or PR as related to cleaning up code, process, or technical debt. size/M Denotes a PR that changes 30-99 lines, ignoring generated files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. do-not-merge/needs-sig Indicates an issue or PR lacks a `sig/foo` label and requires one. needs-triage Indicates an issue or PR lacks a `triage/foo` label and requires one. labels Apr 12, 2021
@k8s-ci-robot
Copy link
Contributor

Hi @lojies. Thanks for your PR.

I'm waiting for a kubernetes member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@k8s-ci-robot k8s-ci-robot added needs-priority Indicates a PR lacks a `priority/foo` label and requires one. needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. area/kubectl sig/cli Categorizes an issue or PR as relevant to SIG CLI. and removed do-not-merge/needs-sig Indicates an issue or PR lacks a `sig/foo` label and requires one. labels Apr 12, 2021
dixudx
dixudx approved these changes Apr 12, 2021
View reviewed changes
Copy link
Member

@dixudx dixudx left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/ok-to-test
/lgtm

@k8s-ci-robot k8s-ci-robot added ok-to-test Indicates a non-member PR verified by an org member that is safe to test. and removed needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. labels Apr 12, 2021
@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Apr 12, 2021
@lojies
Copy link
Contributor Author

lojies commented Apr 12, 2021

/retest

1 similar comment
@lojies
Copy link
Contributor Author

lojies commented Apr 12, 2021

/retest

@dougsland
Copy link
Member

/lgtm

@dougsland
Copy link
Member

/triage accepted
/priority backlog

@k8s-ci-robot k8s-ci-robot added triage/accepted Indicates an issue or PR is ready to be actively worked on. priority/backlog Higher priority than priority/awaiting-more-evidence. and removed needs-triage Indicates an issue or PR lacks a `triage/foo` label and requires one. needs-priority Indicates a PR lacks a `priority/foo` label and requires one. labels Apr 12, 2021
dougsland
dougsland reviewed Apr 12, 2021
View reviewed changes
Copy link
Member

@dougsland dougsland left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@k8s-ci-robot k8s-ci-robot added the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label Apr 23, 2021
@k8s-triage-robot
Copy link

Issues go stale after 90d of inactivity.
Mark the issue as fresh with /remove-lifecycle stale.
Stale issues rot after an additional 30d of inactivity and eventually close.

If this issue is safe to close now please do so with /close.

Send feedback to sig-contributor-experience at kubernetes/community.
/lifecycle stale

@k8s-ci-robot k8s-ci-robot added the lifecycle/stale Denotes an issue or PR has remained open with no activity and has become stale. label Aug 1, 2021
@k8s-triage-robot
Copy link

The Kubernetes project currently lacks enough active contributors to adequately respond to all issues and PRs.

This bot triages issues and PRs according to the following rules:

  • After 90d of inactivity, lifecycle/stale is applied
  • After 30d of inactivity since lifecycle/stale was applied, lifecycle/rotten is applied
  • After 30d of inactivity since lifecycle/rotten was applied, the issue is closed

You can:

  • Mark this issue or PR as fresh with /remove-lifecycle rotten
  • Close this issue or PR with /close
  • Offer to help out with Issue Triage

Please send feedback to sig-contributor-experience at kubernetes/community.

/lifecycle rotten

@k8s-ci-robot k8s-ci-robot added lifecycle/rotten Denotes an issue or PR that has aged beyond stale and will be auto-closed. and removed lifecycle/stale Denotes an issue or PR has remained open with no activity and has become stale. labels Sep 1, 2021
@k8s-triage-robot
Copy link

The Kubernetes project currently lacks enough active contributors to adequately respond to all issues and PRs.

This bot triages issues and PRs according to the following rules:

  • After 90d of inactivity, lifecycle/stale is applied
  • After 30d of inactivity since lifecycle/stale was applied, lifecycle/rotten is applied
  • After 30d of inactivity since lifecycle/rotten was applied, the issue is closed

You can:

  • Reopen this issue or PR with /reopen
  • Mark this issue or PR as fresh with /remove-lifecycle rotten
  • Offer to help out with Issue Triage

Please send feedback to sig-contributor-experience at kubernetes/community.

/close

@k8s-ci-robot
Copy link
Contributor

@k8s-triage-robot: Closed this PR.

In response to this:

The Kubernetes project currently lacks enough active contributors to adequately respond to all issues and PRs.

This bot triages issues and PRs according to the following rules:

  • After 90d of inactivity, lifecycle/stale is applied
  • After 30d of inactivity since lifecycle/stale was applied, lifecycle/rotten is applied
  • After 30d of inactivity since lifecycle/rotten was applied, the issue is closed

You can:

  • Reopen this issue or PR with /reopen
  • Mark this issue or PR as fresh with /remove-lifecycle rotten
  • Offer to help out with Issue Triage

Please send feedback to sig-contributor-experience at kubernetes/community.

/close

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

SIG CLI automation moved this from Needs Approver to Done Oct 1, 2021
@dougsland
Copy link
Member

/reopen

@k8s-ci-robot
Copy link
Contributor

@dougsland: Reopened this PR.

In response to this:

/reopen

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@k8s-ci-robot k8s-ci-robot reopened this Oct 3, 2021
SIG CLI automation moved this from Done to In progress Oct 3, 2021
@dougsland
Copy link
Member

Let's see if CI completes OK after long time.. If completes, @eddiezane seems the person to hit for review/approve.

@k8s-triage-robot
Copy link

The Kubernetes project currently lacks enough active contributors to adequately respond to all issues and PRs.

This bot triages issues and PRs according to the following rules:

  • After 90d of inactivity, lifecycle/stale is applied
  • After 30d of inactivity since lifecycle/stale was applied, lifecycle/rotten is applied
  • After 30d of inactivity since lifecycle/rotten was applied, the issue is closed

You can:

  • Reopen this issue or PR with /reopen
  • Mark this issue or PR as fresh with /remove-lifecycle rotten
  • Offer to help out with Issue Triage

Please send feedback to sig-contributor-experience at kubernetes/community.

/close

@k8s-ci-robot
Copy link
Contributor

@k8s-triage-robot: Closed this PR.

In response to this:

The Kubernetes project currently lacks enough active contributors to adequately respond to all issues and PRs.

This bot triages issues and PRs according to the following rules:

  • After 90d of inactivity, lifecycle/stale is applied
  • After 30d of inactivity since lifecycle/stale was applied, lifecycle/rotten is applied
  • After 30d of inactivity since lifecycle/rotten was applied, the issue is closed

You can:

  • Reopen this issue or PR with /reopen
  • Mark this issue or PR as fresh with /remove-lifecycle rotten
  • Offer to help out with Issue Triage

Please send feedback to sig-contributor-experience at kubernetes/community.

/close

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

SIG CLI automation moved this from In progress to Done Nov 2, 2021
@eddiezane
Copy link
Member

/reopen
/remove-lifecycle rotten

@k8s-ci-robot k8s-ci-robot reopened this Nov 2, 2021
@k8s-ci-robot
Copy link
Contributor

@eddiezane: Reopened this PR.

In response to this:

/reopen
/remove-lifecycle rotten

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

SIG CLI automation moved this from Done to In progress Nov 2, 2021
@k8s-ci-robot k8s-ci-robot removed the lifecycle/rotten Denotes an issue or PR that has aged beyond stale and will be auto-closed. label Nov 2, 2021
eddiezane
eddiezane approved these changes Nov 2, 2021
View reviewed changes
Copy link
Member

@eddiezane eddiezane left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

/approve

@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: dixudx, eddiezane, lojies

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Nov 2, 2021
@ash2k
Copy link
Member

ash2k commented Nov 2, 2021

/retest

@k8s-ci-robot k8s-ci-robot merged commit c2c0f91 into kubernetes:master Nov 3, 2021
SIG CLI automation moved this from In progress to Done Nov 3, 2021
@k8s-ci-robot k8s-ci-robot added this to the v1.23 milestone Nov 3, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@dougsland dougsland dougsland left review comments

@eddiezane eddiezane eddiezane approved these changes

@dixudx dixudx dixudx approved these changes

Assignees

@ash2k ash2k

@dougsland dougsland

@dixudx dixudx

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. area/kubectl cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. kind/cleanup Categorizes issue or PR as related to cleaning up code, process, or technical debt. lgtm "Looks good to me", indicates that a PR is ready to be merged. ok-to-test Indicates a non-member PR verified by an org member that is safe to test. priority/backlog Higher priority than priority/awaiting-more-evidence. release-note-none Denotes a PR that doesn't merit a release note. sig/cli Categorizes an issue or PR as relevant to SIG CLI. size/M Denotes a PR that changes 30-99 lines, ignoring generated files. triage/accepted Indicates an issue or PR is ready to be actively worked on.
Projects
SIG CLI
Done
Milestone
v1.23
Development

Successfully merging this pull request may close these issues.

None yet
7 participants
@lojies @k8s-ci-robot @dougsland @ash2k @k8s-triage-robot @eddiezane @dixudx