Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[1.20][go1.15] Update to go1.15.11 #101192

Merged
merged 4 commits into from Apr 17, 2021
Merged

[1.20][go1.15] Update to go1.15.11 #101192

merged 4 commits into from Apr 17, 2021

Conversation

cpanato
Copy link
Member

@cpanato cpanato commented Apr 16, 2021

What type of PR is this?

/kind feature
/area dependency

What this PR does / why we need it:

  • Update to go1.15.11

Tracking issue: kubernetes/release#1984
Slack thread: https://kubernetes.slack.com/archives/C2C40FMNF/p1617365695206200

/assign @justaugustus @mkumatag @liggitt @dims
cc: @kubernetes/release-engineering

Which issue(s) this PR fixes:

Fixes #

Special notes for your reviewer:

Does this PR introduce a user-facing change?:

- Kubernetes is now built using go1.15.11

Additional documentation e.g., KEPs (Kubernetes Enhancement Proposals), usage docs, etc.:

@k8s-ci-robot k8s-ci-robot added this to the v1.20 milestone Apr 16, 2021
@k8s-ci-robot k8s-ci-robot added the do-not-merge/cherry-pick-not-approved Indicates that a PR is not yet approved to merge into a release branch. label Apr 16, 2021
@k8s-ci-robot k8s-ci-robot added size/M Denotes a PR that changes 30-99 lines, ignoring generated files. kind/feature Categorizes issue or PR as related to a new feature. release-note Denotes a PR that will be considered when it comes time to generate release notes. area/dependency Issues or PRs related to dependency changes cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. do-not-merge/needs-sig Indicates an issue or PR lacks a `sig/foo` label and requires one. needs-triage Indicates an issue or PR lacks a `triage/foo` label and requires one. labels Apr 16, 2021
@cpanato cpanato changed the title [1.20][go1.15] Update to go1.15.1 [1.20][go1.15] Update to go1.15.11 Apr 16, 2021
@k8s-ci-robot k8s-ci-robot added needs-priority Indicates a PR lacks a `priority/foo` label and requires one. area/provider/gcp Issues or PRs related to gcp provider labels Apr 16, 2021
@k8s-ci-robot k8s-ci-robot added area/release-eng Issues or PRs related to the Release Engineering subproject area/test sig/cloud-provider Categorizes an issue or PR as relevant to SIG Cloud Provider. sig/instrumentation Categorizes an issue or PR as relevant to SIG Instrumentation. sig/release Categorizes an issue or PR as relevant to SIG Release. sig/testing Categorizes an issue or PR as relevant to SIG Testing. and removed do-not-merge/needs-sig Indicates an issue or PR lacks a `sig/foo` label and requires one. labels Apr 16, 2021
@cpanato cpanato force-pushed the go11511-release-120 branch 3 times, most recently from 360a81e to a69cd07 Compare April 16, 2021 11:50
@k8s-ci-robot k8s-ci-robot added size/L Denotes a PR that changes 100-499 lines, ignoring generated files. and removed size/M Denotes a PR that changes 30-99 lines, ignoring generated files. labels Apr 16, 2021
@cpanato cpanato requested a review from liggitt April 16, 2021 15:51
@cpanato
Copy link
Member Author

cpanato commented Apr 16, 2021

@liggitt did a format messages and drop a test commit i did before, when you have time can you take a look again? thanks!

@liggitt
Copy link
Member

liggitt commented Apr 16, 2021

/lgtm

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Apr 16, 2021
@justaugustus
Copy link
Member

/test pull-kubernetes-e2e-kind

justaugustus
justaugustus requested changes Apr 16, 2021
View reviewed changes
Copy link
Member

@justaugustus justaugustus left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@cpanato -- Two nits/requests:

  • When specifying override_go_version, you should not need to specify go_version in build/root/WORKSPACE
  • It's fine to leave the changes in staging/publishing/rules.yaml for cosmetic purposes and to satisfy the dependency script, but for them to take effect, they need to be made on master

build/root/WORKSPACE Outdated Show resolved Hide resolved
@cpanato
Copy link
Member Author

cpanato commented Apr 16, 2021

/hold will update based on feedback tomorrow

@k8s-ci-robot k8s-ci-robot removed the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Apr 17, 2021
@cpanato
Copy link
Member Author

cpanato commented Apr 17, 2021

/hold cancel
/priority important-soon
/triage accepted

@k8s-ci-robot k8s-ci-robot added priority/important-soon Must be staffed and worked on either currently, or very soon, ideally in time for the next release. triage/accepted Indicates an issue or PR is ready to be actively worked on. and removed do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. needs-priority Indicates a PR lacks a `priority/foo` label and requires one. needs-triage Indicates an issue or PR lacks a `triage/foo` label and requires one. labels Apr 17, 2021
@cpanato
Copy link
Member Author

cpanato commented Apr 17, 2021

/retest

@justaugustus justaugustus added the cherry-pick-approved Indicates a cherry-pick PR into a release branch has been approved by the release branch manager. label Apr 17, 2021
@k8s-ci-robot k8s-ci-robot removed the do-not-merge/cherry-pick-not-approved Indicates that a PR is not yet approved to merge into a release branch. label Apr 17, 2021
@justaugustus
Copy link
Member

/lgtm
/approve

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Apr 17, 2021
@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: cpanato, justaugustus, liggitt

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot merged commit 7e0a8fc into kubernetes:release-1.20 Apr 17, 2021
@cpanato cpanato deleted the go11511-release-120 branch April 17, 2021 13:43
@justaugustus justaugustus mentioned this pull request Apr 18, 2021
Merged
@github-actions github-actions bot mentioned this pull request Apr 21, 2021
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@BenTheElder BenTheElder Awaiting requested review from BenTheElder

@liggitt liggitt Awaiting requested review from liggitt

@justaugustus justaugustus Awaiting requested review from justaugustus

Assignees

@dims dims

@justaugustus justaugustus

@liggitt liggitt

@mkumatag mkumatag

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. area/dependency Issues or PRs related to dependency changes area/provider/gcp Issues or PRs related to gcp provider area/release-eng Issues or PRs related to the Release Engineering subproject area/test cherry-pick-approved Indicates a cherry-pick PR into a release branch has been approved by the release branch manager. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. kind/feature Categorizes issue or PR as related to a new feature. lgtm "Looks good to me", indicates that a PR is ready to be merged. priority/important-soon Must be staffed and worked on either currently, or very soon, ideally in time for the next release. release-note Denotes a PR that will be considered when it comes time to generate release notes. sig/cloud-provider Categorizes an issue or PR as relevant to SIG Cloud Provider. sig/instrumentation Categorizes an issue or PR as relevant to SIG Instrumentation. sig/release Categorizes an issue or PR as relevant to SIG Release. sig/testing Categorizes an issue or PR as relevant to SIG Testing. size/M Denotes a PR that changes 30-99 lines, ignoring generated files. triage/accepted Indicates an issue or PR is ready to be actively worked on.
Projects
None yet
Milestone
v1.20
Development

Successfully merging this pull request may close these issues.

None yet
6 participants
@cpanato @liggitt @justaugustus @k8s-ci-robot @dims @mkumatag