-
Notifications
You must be signed in to change notification settings - Fork 39.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[1.20][go1.15] Update to go1.15.11 #101192
[1.20][go1.15] Update to go1.15.11 #101192
Conversation
360a81e
to
a69cd07
Compare
@liggitt did a format messages and drop a test commit i did before, when you have time can you take a look again? thanks! |
/lgtm |
/test pull-kubernetes-e2e-kind |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@cpanato -- Two nits/requests:
- When specifying
override_go_version
, you should not need to specifygo_version
inbuild/root/WORKSPACE
- It's fine to leave the changes in
staging/publishing/rules.yaml
for cosmetic purposes and to satisfy the dependency script, but for them to take effect, they need to be made onmaster
/hold will update based on feedback tomorrow |
69f3957
to
1978727
Compare
/hold cancel |
/retest |
/lgtm |
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: cpanato, justaugustus, liggitt The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
What type of PR is this?
/kind feature
/area dependency
What this PR does / why we need it:
Tracking issue: kubernetes/release#1984
Slack thread: https://kubernetes.slack.com/archives/C2C40FMNF/p1617365695206200
/assign @justaugustus @mkumatag @liggitt @dims
cc: @kubernetes/release-engineering
Which issue(s) this PR fixes:
Fixes #
Special notes for your reviewer:
Does this PR introduce a user-facing change?:
Additional documentation e.g., KEPs (Kubernetes Enhancement Proposals), usage docs, etc.: