Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

kubelet_running_pods shows number of pods that have a running pod sandbox #101308

Merged
merged 1 commit into from May 26, 2021
Merged

kubelet_running_pods shows number of pods that have a running pod sandbox #101308

merged 1 commit into from May 26, 2021

Conversation

pacoxu
Copy link
Member

@pacoxu pacoxu commented Apr 21, 2021 •
edited

What type of PR is this?

/kind documentation

What this PR does / why we need it:

To make it much clearer:

Number of pods currently running
to
Number of pods that have a running pod sandbox

Which issue(s) this PR fixes:

Fixes #99624

Special notes for your reviewer:

#99624 (comment)

IIRC, kubelet_running_pods is not intended to reflect the pod phase in the API server.

It is used to expose the kubelet internal state: how many pods have running containers in the container runtime, and mainly for debugging purpose.

Does this PR introduce a user-facing change?

NONE

@k8s-ci-robot k8s-ci-robot added release-note-none Denotes a PR that doesn't merit a release note. kind/documentation Categorizes issue or PR as related to documentation. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. do-not-merge/needs-sig Indicates an issue or PR lacks a `sig/foo` label and requires one. needs-triage Indicates an issue or PR lacks a `triage/foo` label and requires one. needs-priority Indicates a PR lacks a `priority/foo` label and requires one. area/kubelet sig/instrumentation Categorizes an issue or PR as relevant to SIG Instrumentation. sig/node Categorizes an issue or PR as relevant to SIG Node. and removed do-not-merge/needs-sig Indicates an issue or PR lacks a `sig/foo` label and requires one. labels Apr 21, 2021
@matthyx
Copy link
Contributor

matthyx commented Apr 21, 2021

/priority important-longterm
/lgtm
/triage accepted

@k8s-ci-robot k8s-ci-robot added priority/important-longterm Important over the long term, but may not be staffed and/or may need multiple releases to complete. triage/accepted Indicates an issue or PR is ready to be actively worked on. and removed needs-priority Indicates a PR lacks a `priority/foo` label and requires one. needs-triage Indicates an issue or PR lacks a `triage/foo` label and requires one. labels Apr 21, 2021
@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Apr 21, 2021
@harche harche mentioned this pull request Apr 21, 2021
Closed
@ehashman ehashman added this to Needs Approver in SIG Node PR Triage Apr 21, 2021
@k8s-ci-robot k8s-ci-robot removed the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Apr 22, 2021
@pacoxu pacoxu requested a review from Random-Liu April 23, 2021 07:16
derekwaynecarr
derekwaynecarr requested changes Apr 27, 2021
View reviewed changes
Copy link
Member

@derekwaynecarr derekwaynecarr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

the pause container is an implementation detail.

we should reference the presence of a running pod sandbox instead.

pkg/kubelet/metrics/metrics.go Outdated Show resolved Hide resolved
@derekwaynecarr derekwaynecarr moved this from Needs Approver to Needs Reviewer in SIG Node PR Triage Apr 27, 2021
ehashman
ehashman reviewed Apr 28, 2021
View reviewed changes
pkg/kubelet/metrics/metrics.go Outdated Show resolved Hide resolved
pkg/kubelet/metrics/metrics.go Outdated Show resolved Hide resolved
pkg/kubelet/pleg/generic_test.go Outdated Show resolved Hide resolved
@ehashman ehashman moved this from Needs Reviewer to Waiting on Author in SIG Node PR Triage Apr 28, 2021
@pacoxu @ehashman
update kubelet_running_pods metrics comments: pods that have a runnin…
6506664 
…g pod sandbox

Signed-off-by: pacoxu <paco.xu@daocloud.io>
Co-authored-by: Elana Hashman <ehashman@users.noreply.github.com>
@pacoxu
Copy link
Member Author

pacoxu commented Apr 29, 2021

Updated. Typo 😓

@pacoxu pacoxu requested a review from ehashman April 29, 2021 03:10
@ehashman ehashman moved this from Waiting on Author to Needs Reviewer in SIG Node PR Triage May 19, 2021
@pacoxu pacoxu changed the title update kubelet_running_pods metrics docs: pods in running phase kubelet_running_pods shows number of pods that have a running pod sandbox May 20, 2021
ehashman
ehashman approved these changes May 25, 2021
View reviewed changes
Copy link
Member

@ehashman ehashman left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label May 25, 2021
@ehashman ehashman moved this from Needs Reviewer to Needs Approver in SIG Node PR Triage May 25, 2021
@Random-Liu
Copy link
Member

/lgtm
/approve

@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: ehashman, pacoxu, Random-Liu

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label May 25, 2021
@ehashman ehashman moved this from Needs Approver to Done in SIG Node PR Triage May 25, 2021
@pacoxu
Copy link
Member Author

pacoxu commented May 26, 2021

/test pull-kubernetes-node-e2e-containerd
for CI hang

@pacoxu
Copy link
Member Author

pacoxu commented May 26, 2021

/retest

1 similar comment
@pacoxu
Copy link
Member Author

pacoxu commented May 26, 2021

/retest

@k8s-ci-robot k8s-ci-robot merged commit 91656fa into kubernetes:master May 26, 2021
@k8s-ci-robot k8s-ci-robot added this to the v1.22 milestone May 26, 2021
@pacoxu pacoxu deleted the doc-kubelet-running-pods branch June 23, 2021 05:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ehashman ehashman ehashman approved these changes

@matthyx matthyx Awaiting requested review from matthyx

@mrunalp mrunalp Awaiting requested review from mrunalp

@Random-Liu Random-Liu Awaiting requested review from Random-Liu

@derekwaynecarr derekwaynecarr Awaiting requested review from derekwaynecarr

Assignees

@ehashman ehashman

@Random-Liu Random-Liu

@matthyx matthyx

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. area/kubelet cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. kind/documentation Categorizes issue or PR as related to documentation. lgtm "Looks good to me", indicates that a PR is ready to be merged. priority/important-longterm Important over the long term, but may not be staffed and/or may need multiple releases to complete. release-note-none Denotes a PR that doesn't merit a release note. sig/instrumentation Categorizes an issue or PR as relevant to SIG Instrumentation. sig/node Categorizes an issue or PR as relevant to SIG Node. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. triage/accepted Indicates an issue or PR is ready to be actively worked on.
Projects
SIG Node PR Triage
Done
Milestone
v1.22
Development

Successfully merging this pull request may close these issues.

kubelet_running_pods metric includes Pending pods
6 participants
@pacoxu @matthyx @Random-Liu @k8s-ci-robot @ehashman @derekwaynecarr