Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

When referencing a package named "github.com/mrunalp/fileutils", ci found that there are two variables undefined #101970

Closed
lunhuijie opened this issue May 13, 2021 · 7 comments
Labels
needs-sig Indicates an issue or PR lacks a `sig/foo` label and requires one. needs-triage Indicates an issue or PR lacks a `triage/foo` label and requires one.

Comments

@lunhuijie
Copy link
Contributor

What happened:

I wrote a test case and referenced this package(github.com/mrunalp/fileutils) to copy the folder,the function is fileutils.CopyDirectory. CI reported an error.
image

What you expected to happen:

CI pass without "pull-kubernetes-typecheck — Job failed."

How to reproduce it (as minimally and precisely as possible):

Anything else we need to know?:

More details:
#101959

Environment:

  • Kubernetes version (use kubectl version):
  • Cloud provider or hardware configuration:
  • OS (e.g: cat /etc/os-release):
  • Kernel (e.g. uname -a):
  • Install tools:
  • Network plugin and version (if this is a network-related bug):
  • Others:
@lunhuijie lunhuijie added the kind/bug Categorizes issue or PR as related to a bug. label May 13, 2021
@k8s-ci-robot k8s-ci-robot added the needs-sig Indicates an issue or PR lacks a `sig/foo` label and requires one. label May 13, 2021
@k8s-ci-robot
Copy link
Contributor

@lunhuijie: This issue is currently awaiting triage.

If a SIG or subproject determines this is a relevant issue, they will accept it by applying the triage/accepted label and provide further guidance.

The triage/accepted label can be added by org members by writing /triage accepted in a comment.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@k8s-ci-robot k8s-ci-robot added the needs-triage Indicates an issue or PR lacks a `triage/foo` label and requires one. label May 13, 2021
@lunhuijie
Copy link
Contributor Author

lunhuijie commented May 13, 2021

@mrunalp I read the relevant source code and found that there is a definition. So why is CI failed but could you help me take a look?
I would be very grateful for your help!

@lunhuijie
Copy link
Contributor Author

/sig testing

@k8s-ci-robot k8s-ci-robot added sig/testing Categorizes an issue or PR as relevant to SIG Testing. and removed needs-sig Indicates an issue or PR lacks a `sig/foo` label and requires one. labels May 13, 2021
@alberthuang24
Copy link

alberthuang24 commented May 13, 2021

It is detected that fileutils does not support windows-386 and windows-arm

@BenTheElder
Copy link
Member

this is not a bug, it's as mentioned above: typecheck ensures that the kubernetes will compile for all supported platforms by typechecking it.

you must either use cross platform code, or have platform specific versions gated by build tags / platform specific files.

/remove-sig testing
/remove-kind bug
/close

@k8s-ci-robot k8s-ci-robot added needs-sig Indicates an issue or PR lacks a `sig/foo` label and requires one. and removed sig/testing Categorizes an issue or PR as relevant to SIG Testing. kind/bug Categorizes issue or PR as related to a bug. labels May 13, 2021
@k8s-ci-robot
Copy link
Contributor

@lunhuijie: There are no sig labels on this issue. Please add an appropriate label by using one of the following commands:

  • /sig <group-name>
  • /wg <group-name>
  • /committee <group-name>

Please see the group list for a listing of the SIGs, working groups, and committees available.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@k8s-ci-robot
Copy link
Contributor

@BenTheElder: Closing this issue.

In response to this:

this is not a bug, it's as mentioned above: typecheck ensures that the kubernetes will compile for all supported platforms by typechecking it.

you must either use cross platform code, or have platform specific versions gated by build tags / platform specific files.

/remove-sig testing
/remove-kind bug
/close

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
needs-sig Indicates an issue or PR lacks a `sig/foo` label and requires one. needs-triage Indicates an issue or PR lacks a `triage/foo` label and requires one.
Projects
None yet
Development

No branches or pull requests

4 participants