Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

clean up algorithmprovider pkg and remove scheduler deprecated algorithm-provider flag #102239

Conversation

Haleygo
Copy link
Contributor

@Haleygo Haleygo commented May 24, 2021

What type of PR is this?

/kind feature

What this PR does / why we need it:

  1. Remove AlgorithmProvider flag in scheduler. This flag was marked as deprecated since v1.17.
  2. clean up algorithmprovider pkg, only preserve default plugin setting

Which issue(s) this PR fixes:

Fixes #102151

Special notes for your reviewer:

Does this PR introduce a user-facing change?

The deprecated flag --algorithm-provider has been removed from kube-scheduler. Use instead ComponentConfig to configure the set of enabled plugins

Additional documentation e.g., KEPs (Kubernetes Enhancement Proposals), usage docs, etc.:


@k8s-ci-robot k8s-ci-robot added kind/cleanup Categorizes issue or PR as related to cleaning up code, process, or technical debt. size/XL Denotes a PR that changes 500-999 lines, ignoring generated files. do-not-merge/release-note-label-needed Indicates that a PR should not merge because it's missing one of the release note labels. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. do-not-merge/needs-sig Indicates an issue or PR lacks a `sig/foo` label and requires one. needs-triage Indicates an issue or PR lacks a `triage/foo` label and requires one. labels May 24, 2021
@k8s-ci-robot
Copy link
Contributor

@Haleygo: This issue is currently awaiting triage.

If a SIG or subproject determines this is a relevant issue, they will accept it by applying the triage/accepted label and provide further guidance.

The triage/accepted label can be added by org members by writing /triage accepted in a comment.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@k8s-ci-robot k8s-ci-robot added needs-priority Indicates a PR lacks a `priority/foo` label and requires one. needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. labels May 24, 2021
@k8s-ci-robot
Copy link
Contributor

Hi @Haleygo. Thanks for your PR.

I'm waiting for a kubernetes member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@k8s-ci-robot k8s-ci-robot requested review from adtac and damemi May 24, 2021 05:45
@k8s-ci-robot k8s-ci-robot added area/provider/gcp Issues or PRs related to gcp provider sig/cloud-provider Categorizes an issue or PR as relevant to SIG Cloud Provider. sig/scheduling Categorizes an issue or PR as relevant to SIG Scheduling. release-note Denotes a PR that will be considered when it comes time to generate release notes. and removed do-not-merge/needs-sig Indicates an issue or PR lacks a `sig/foo` label and requires one. do-not-merge/release-note-label-needed Indicates that a PR should not merge because it's missing one of the release note labels. labels May 24, 2021
@pacoxu
Copy link
Member

pacoxu commented May 24, 2021

/ok-to-test
/cc ahg-g

@k8s-ci-robot k8s-ci-robot requested a review from ahg-g May 24, 2021 07:07
@k8s-ci-robot k8s-ci-robot added ok-to-test Indicates a non-member PR verified by an org member that is safe to test. and removed needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. labels May 24, 2021
@Haleygo Haleygo force-pushed the clean-up-AlgorithmProvider-flag-and-pkg branch from 683f14d to bc26833 Compare May 24, 2021 08:43
@k8s-ci-robot k8s-ci-robot added the kind/api-change Categorizes issue or PR as related to adding, removing, or otherwise changing an API label May 24, 2021
@Haleygo Haleygo force-pushed the clean-up-AlgorithmProvider-flag-and-pkg branch from bc26833 to 431a8a5 Compare May 24, 2021 09:01
@Haleygo
Copy link
Contributor Author

Haleygo commented May 24, 2021

/retest

@fejta-bot
Copy link

This PR may require API review.

If so, when the changes are ready, complete the pre-review checklist and request an API review.

Status of requested reviews is tracked in the API Review project.

@@ -1,178 +0,0 @@
/*
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Keep this pkg for now, only remove the flag. The pkg will be removed in the same PR that adds the set of default plugins to the defaulting logic.

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

pkg/scheduler/algorithmprovider/registry.go Show resolved Hide resolved
pkg/scheduler/algorithmprovider/registry.go Show resolved Hide resolved
pkg/scheduler/algorithmprovider/registry.go Show resolved Hide resolved
pkg/scheduler/algorithmprovider/registry.go Show resolved Hide resolved
pkg/scheduler/factory.go Outdated Show resolved Hide resolved
@Haleygo Haleygo force-pushed the clean-up-AlgorithmProvider-flag-and-pkg branch from 431a8a5 to 7e9e12c Compare May 25, 2021 08:06
@k8s-ci-robot k8s-ci-robot removed the lgtm "Looks good to me", indicates that a PR is ready to be merged. label May 26, 2021
@Haleygo Haleygo changed the title remove scheduler deprecated algorithm-provider flag clean up algorithmprovider pkg and remove scheduler deprecated algorithm-provider flag May 26, 2021
@Haleygo
Copy link
Contributor Author

Haleygo commented May 26, 2021

/lgtm

for the scheduler

@ahg-g So sorry, I thought remove flag and clean up pkg should divided into two commits and I have rebased commits now, but the /lgtm label been removed.

@liggitt liggitt added this to In progress in API Reviews May 26, 2021
@liggitt
Copy link
Member

liggitt commented May 26, 2021

This is the flag we discussed removing offline. Can you PTAL?

looking today

@roycaihw
Copy link
Member

The deprecation looks good to me. Could you update the release note to mention the website documentation about the replacement of the flag? https://kubernetes.io/docs/reference/scheduling/config/

Ideally the documentation should mention how should the ComponentConfig look like if a system admin is using the deprecated algorithm-provider flag is certain ways today.

@liggitt
Copy link
Member

liggitt commented May 26, 2021

/approve

deprecation policy for admin-facing CLI flags is "GA, admin-facing flag, longer of 6 months or 1 release"

verified deprecated since 1.17 - https://github.com/kubernetes/kubernetes/blob/release-1.17/cmd/kube-scheduler/app/options/deprecated.go#L47

@liggitt liggitt moved this from In progress to API review completed, 1.22 in API Reviews May 26, 2021
@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: Haleygo, liggitt

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label May 26, 2021
@ahg-g
Copy link
Member

ahg-g commented May 26, 2021

/retest

@ahg-g
Copy link
Member

ahg-g commented May 26, 2021

/lgtm

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label May 26, 2021
@fejta-bot
Copy link

/retest
This bot automatically retries jobs that failed/flaked on approved PRs (send feedback to fejta).

Review the full test history for this PR.

Silence the bot with an /lgtm cancel or /hold comment for consistent failures.

@Haleygo
Copy link
Contributor Author

Haleygo commented May 27, 2021

/retest

@Haleygo
Copy link
Contributor Author

Haleygo commented May 27, 2021

/test pull-kubernetes-e2e-gce-ubuntu-containerd

@pacoxu
Copy link
Member

pacoxu commented May 27, 2021

/retest
volume flake?

@pacoxu
Copy link
Member

pacoxu commented May 27, 2021

Flake: MetricsGrabber should grab all metrics from a Scheduler
/retest

@k8s-ci-robot k8s-ci-robot merged commit d541872 into kubernetes:master May 27, 2021
@k8s-ci-robot k8s-ci-robot added this to the v1.22 milestone May 27, 2021
@Haleygo Haleygo deleted the clean-up-AlgorithmProvider-flag-and-pkg branch May 29, 2021 14:59
@Haleygo
Copy link
Contributor Author

Haleygo commented Jun 22, 2021

/kind feature

@k8s-ci-robot k8s-ci-robot added the kind/feature Categorizes issue or PR as related to a new feature. label Jun 22, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
api-review Categorizes an issue or PR as actively needing an API review. approved Indicates a PR has been approved by an approver from all required OWNERS files. area/provider/gcp Issues or PRs related to gcp provider cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. kind/api-change Categorizes issue or PR as related to adding, removing, or otherwise changing an API kind/cleanup Categorizes issue or PR as related to cleaning up code, process, or technical debt. kind/feature Categorizes issue or PR as related to a new feature. lgtm "Looks good to me", indicates that a PR is ready to be merged. needs-triage Indicates an issue or PR lacks a `triage/foo` label and requires one. ok-to-test Indicates a non-member PR verified by an org member that is safe to test. priority/important-soon Must be staffed and worked on either currently, or very soon, ideally in time for the next release. release-note Denotes a PR that will be considered when it comes time to generate release notes. sig/cloud-provider Categorizes an issue or PR as relevant to SIG Cloud Provider. sig/scheduling Categorizes an issue or PR as relevant to SIG Scheduling. size/L Denotes a PR that changes 100-499 lines, ignoring generated files.
Projects
Status: API review completed, 1.22
Development

Successfully merging this pull request may close these issues.

Deprecate AlgorithmProvider flag and algorithmProvider scheduler pkg
8 participants