-
Notifications
You must be signed in to change notification settings - Fork 38.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
clean up algorithmprovider pkg and remove scheduler deprecated algorithm-provider flag #102239
clean up algorithmprovider pkg and remove scheduler deprecated algorithm-provider flag #102239
Conversation
@Haleygo: This issue is currently awaiting triage. If a SIG or subproject determines this is a relevant issue, they will accept it by applying the The Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
Hi @Haleygo. Thanks for your PR. I'm waiting for a kubernetes member to verify that this patch is reasonable to test. If it is, they should reply with Once the patch is verified, the new status will be reflected by the I understand the commands that are listed here. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
/ok-to-test |
683f14d
to
bc26833
Compare
bc26833
to
431a8a5
Compare
/retest |
This PR may require API review. If so, when the changes are ready, complete the pre-review checklist and request an API review. Status of requested reviews is tracked in the API Review project. |
@@ -1,178 +0,0 @@ | |||
/* |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Keep this pkg for now, only remove the flag. The pkg will be removed in the same PR that adds the set of default plugins to the defaulting logic.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
/cc @yuzhiquan
431a8a5
to
7e9e12c
Compare
@ahg-g So sorry, I thought remove flag and clean up pkg should divided into two commits and I have rebased commits now, but the /lgtm label been removed. |
looking today |
The deprecation looks good to me. Could you update the release note to mention the website documentation about the replacement of the flag? https://kubernetes.io/docs/reference/scheduling/config/ Ideally the documentation should mention how should the ComponentConfig look like if a system admin is using the deprecated algorithm-provider flag is certain ways today. |
/approve deprecation policy for admin-facing CLI flags is "GA, admin-facing flag, longer of 6 months or 1 release" verified deprecated since 1.17 - https://github.com/kubernetes/kubernetes/blob/release-1.17/cmd/kube-scheduler/app/options/deprecated.go#L47 |
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: Haleygo, liggitt The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
/retest |
/lgtm |
/retest Review the full test history for this PR. Silence the bot with an |
/retest |
/test pull-kubernetes-e2e-gce-ubuntu-containerd |
/retest |
Flake: MetricsGrabber should grab all metrics from a Scheduler |
/kind feature |
What type of PR is this?
/kind feature
What this PR does / why we need it:
Which issue(s) this PR fixes:
Fixes #102151
Special notes for your reviewer:
Does this PR introduce a user-facing change?
Additional documentation e.g., KEPs (Kubernetes Enhancement Proposals), usage docs, etc.: