Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Part2: master to controlplane in test/integration(1.22) #102272

Merged
merged 1 commit into from May 28, 2021
Merged

Part2: master to controlplane in test/integration(1.22) #102272

merged 1 commit into from May 28, 2021

Conversation

mengjiao-liu
Copy link
Member

@mengjiao-liu mengjiao-liu commented May 25, 2021 •
edited

What type of PR is this?

/kind cleanup
/wg naming
/area test

What this PR does / why we need it:

Part of master to controlplane in test/integration

  • NewIntegrationTestMasterConfig -> NewIntegrationTestControlPlaneConfig
  • NewIntegrationTestMasterConfigWithOptions -> NewIntegrationTestControlPlaneConfigWithOptions

Which issue(s) this PR fixes:

Ref #94900

Special notes for your reviewer:

Does this PR introduce a user-facing change?

NONE

Additional documentation e.g., KEPs (Kubernetes Enhancement Proposals), usage docs, etc.:

@mengjiao-liu
Part of master to controlplane in test/integration
c9ec486 
Rename NewIntegrationTestMasterConfig to NewIntegrationTestControlPlaneConfig
@k8s-ci-robot k8s-ci-robot added release-note-none Denotes a PR that doesn't merit a release note. kind/cleanup Categorizes issue or PR as related to cleaning up code, process, or technical debt. wg/naming Categorizes an issue or PR as relevant to WG Naming. size/L Denotes a PR that changes 100-499 lines, ignoring generated files. area/test cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. needs-triage Indicates an issue or PR lacks a `triage/foo` label and requires one. needs-priority Indicates a PR lacks a `priority/foo` label and requires one. sig/apps Categorizes an issue or PR as relevant to SIG Apps. sig/testing Categorizes an issue or PR as relevant to SIG Testing. labels May 25, 2021
@mengjiao-liu mengjiao-liu changed the title Rename NewIntegrationTestMasterConfig to NewIntegrationTestControlPlaneConfig Part2: master to controlplane in test/integration May 25, 2021
@mengjiao-liu mengjiao-liu changed the title Part2: master to controlplane in test/integration Part2: master to controlplane in test/integration(1.22) May 25, 2021
@mengjiao-liu
Copy link
Member Author

/assign @fejta

@mengjiao-liu
Copy link
Member Author

/triage accepted

@k8s-ci-robot k8s-ci-robot added triage/accepted Indicates an issue or PR is ready to be actively worked on. and removed needs-triage Indicates an issue or PR lacks a `triage/foo` label and requires one. labels May 27, 2021
@fejta
Copy link
Contributor

fejta commented May 27, 2021

/approve

@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: fejta, mengjiao-liu

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label May 27, 2021
@wzshiming
Copy link
Member

/lgtm

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label May 28, 2021
@k8s-ci-robot k8s-ci-robot merged commit fc9aace into kubernetes:master May 28, 2021
@k8s-ci-robot k8s-ci-robot added this to the v1.22 milestone May 28, 2021
@pacoxu pacoxu mentioned this pull request Jun 4, 2021
Merged
16 tasks
@mengjiao-liu mengjiao-liu mentioned this pull request Jul 9, 2021
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@johnSchnake johnSchnake Awaiting requested review from johnSchnake

@krmayankk krmayankk Awaiting requested review from krmayankk

Assignees

@fejta fejta

@wzshiming wzshiming

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. area/test cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. kind/cleanup Categorizes issue or PR as related to cleaning up code, process, or technical debt. lgtm "Looks good to me", indicates that a PR is ready to be merged. needs-priority Indicates a PR lacks a `priority/foo` label and requires one. release-note-none Denotes a PR that doesn't merit a release note. sig/apps Categorizes an issue or PR as relevant to SIG Apps. sig/testing Categorizes an issue or PR as relevant to SIG Testing. size/L Denotes a PR that changes 100-499 lines, ignoring generated files. triage/accepted Indicates an issue or PR is ready to be actively worked on. wg/naming Categorizes an issue or PR as relevant to WG Naming.
Projects
None yet
Milestone
v1.22
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@mengjiao-liu @fejta @k8s-ci-robot @wzshiming