Skip node container manager test on systemd #102395
Conversation
k8s-ci-robot
added
release-note-none
k8s-ci-robot
added
area/test
sig/node
|
/test pull-kubernetes-unit |
|
/test pr-node-kubelet-serial-crio-cgroupv1 |
|
@odinuge: The specified target(s) for
Use
In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
|
/test pull-node-kubelet-serial-crio-cgroupv1 |
|
@odinuge: The specified target(s) for
Use
In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
|
ouf /test pull-kubernetes-node-kubelet-serial-crio-cgroupv1 |
SergeyKanzhelev
moved this from Triage
to PRs - Needs Reviewer
in SIG Node CI/Test Board
|
/assign @cynepco3hahue Tests seems to be failing, moving to "waiting on author column" |
k8s-ci-robot
added
priority/important-soon
SergeyKanzhelev
moved this from PRs - Needs Reviewer
to PRs Waiting on Author
in SIG Node CI/Test Board
|
Hi @SergeyKanzhelev,
Ahh, those failures in |
|
/lgtm |
k8s-ci-robot
added
the
lgtm
|
/test pull-kubernetes-node-crio-cgrpv2-e2e |
|
/skip |
|
Ping @SergeyKanzhelev ^^^ Can you move this to "Needs Approver" instead? I don't seem to have permissions to edit that board.... 🤔 |
SergeyKanzhelev
moved this from PRs Waiting on Author
to PRs - Needs Approver
in SIG Node CI/Test Board
| @@ -166,6 +167,15 @@ func runTest(f *framework.Framework) error { | |||
| return err | |||
| } | |||
|
|
|||
| // Test needs to be updated to make it run properly on systemd. | |||
There was a problem hiding this comment.
nit: Better to put TODO: on the front of this line to understand it easily.
|
just recording the failure: I think the error is related to not providing a fully qualified cgroup name in the updated unit when on systemd. /approve |
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: derekwaynecarr, odinuge The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
k8s-ci-robot
added
the
approved
|
this change is also eligible for test-freeze IMO, but milestone-ing. |
|
/retest Review the full test history for this PR. Silence the bot with an |
1 similar comment
|
/retest Review the full test history for this PR. Silence the bot with an |
|
@odinuge: The following tests failed, say
Full PR test history. Your PR dashboard. Please help us cut down on flakes by linking to an open issue when you hit one in your PR. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here. |
|
/retest |
What type of PR is this?
/kind failing-test
What this PR does / why we need it:
This test causes the test suite to fail and abort everything since the applied kubelet configuration is invalid.
It will now skip the test when running on systemd. This will allow test suite to continue.
Which issue(s) this PR fixes:
Fixes #
xref: #102394
Special notes for your reviewer:
Does this PR introduce a user-facing change?
Additional documentation e.g., KEPs (Kubernetes Enhancement Proposals), usage docs, etc.: