Automated cherry pick of #102059: Bump k8s.io/utils #101862: Retry detaching FibreChannel volume few times #102656
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@jsafrane: This cherry pick PR is for a release branch and has not yet been approved by Release Managers. To merge this cherry pick, it must first be approved ( AFTER it has been approved by code owners, please ping the kubernetes/release-managers team in a comment to request a cherry pick review. (For details on the patch release process and schedule, see the Patch Releases page.) Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
k8s-ci-robot
added
do-not-merge/cherry-pick-not-approved
k8s-ci-robot
added
sig/cloud-provider
|
/kind bug |
k8s-ci-robot
added
kind/bug
|
Updated k8s.io/utils to the same SHA as today's k/k master. |
|
/lgtm |
k8s-ci-robot
added
the
lgtm
|
I can confirm this change is limited to fc and iscsi volume plugins. /approve |
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: jsafrane, liggitt The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
k8s-ci-robot
added
the
approved
k8s-ci-robot
added
the
needs-rebase
jsafrane
force-pushed
the
automated-cherry-pick-of-#102059-#101862-upstream-release-1.21
branch
from
aec7814
to
ba5f038
Compare
k8s-ci-robot
removed
lgtm
k8s-ci-robot
added
the
needs-rebase
jsafrane
force-pushed
the
automated-cherry-pick-of-#102059-#101862-upstream-release-1.21
branch
from
ba5f038
to
385024a
Compare
To get io/ConsistentRead updates.
We've seen clusters where 3 attempts were not enough. Bumping to 10. The slowdown should be negligible and it will reduce retry attempts in the upper layers of kubelet.
…ruction iSCSI and FC volume plugins do not implement real 3rd party attach/detach. If reconstruction fails with an error on a FC or iSCSI volume, it will not be unmounted from the volume global dir and at the same time it will be marked as unused, to be available to be mounted on another node. The volume can then be mounted on several nodes, resulting in volume corruption. The other block based volume plugins implement attach/detach that either makes the volume stuck (can't be detached) or will be force-detached from a node before attaching it somewhere else.
Move reporting of GetReliableMountRefs error to the volume plugins that have more context about severity of the error.
Run hack/update-vendor.sh to get the new file.
When UnmountDevice() of a FibreChannel volume fails after unmounting the device and before the device is fully cleaned up, subsequent UnmountDevice() retry won't find the device mounted and return without retrying the device cleanup. Therefore implement its own retry inside UnmountDevice() to make sure that the volume devices are either fully cleaned or the error is serius enough that even 1 minute of trying does not help.
jsafrane
force-pushed
the
automated-cherry-pick-of-#102059-#101862-upstream-release-1.21
branch
from
385024a
to
b973d29
Compare
k8s-ci-robot
removed
the
needs-rebase
|
/lgtm |
k8s-ci-robot
added
the
lgtm
justaugustus
added
the
cherry-pick-approved
k8s-ci-robot
removed
the
do-not-merge/cherry-pick-not-approved
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Cherry pick of #102059 #101862 on release-1.21.
#102059: Retry reading /proc/mounts when unable to get a consistent read
#101862: Retry detaching FibreChannel volume few times
For details on the cherry pick process, see the cherry pick requests page.
Note:
k8s.io/utilsmaster tok/krelease-1.21branch, which sounds scary, but in the end there were just one extra file k8s.io/utils/pointer/pointer.go changed.hack/update-vendor.shto get everything from k8s.io/utils.Release note manually copied from the PRs above: