Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Move scheduler plugin set and configuration defaulting to CC #102796

Merged
merged 1 commit into from Jun 16, 2021
Merged

Move scheduler plugin set and configuration defaulting to CC #102796

merged 1 commit into from Jun 16, 2021

Conversation

ahg-g
Copy link
Member

@ahg-g ahg-g commented Jun 10, 2021

What type of PR is this?

/kind feature

What this PR does / why we need it:

Moves scheduler plugin and plugin config defaulting to its canonical place, component config.

Which issue(s) this PR fixes:

Fixes #102211

Special notes for your reviewer:

Does this PR introduce a user-facing change?

NONE

@k8s-ci-robot k8s-ci-robot added release-note-none Denotes a PR that doesn't merit a release note. kind/feature Categorizes issue or PR as related to a new feature. size/XXL Denotes a PR that changes 1000+ lines, ignoring generated files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. do-not-merge/needs-sig Indicates an issue or PR lacks a `sig/foo` label and requires one. labels Jun 10, 2021
@k8s-ci-robot
Copy link
Contributor

@ahg-g: This issue is currently awaiting triage.

If a SIG or subproject determines this is a relevant issue, they will accept it by applying the triage/accepted label and provide further guidance.

The triage/accepted label can be added by org members by writing /triage accepted in a comment.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@k8s-ci-robot k8s-ci-robot added needs-triage Indicates an issue or PR lacks a `triage/foo` label and requires one. needs-priority Indicates a PR lacks a `priority/foo` label and requires one. area/test kind/api-change Categorizes issue or PR as related to adding, removing, or otherwise changing an API sig/scheduling Categorizes an issue or PR as relevant to SIG Scheduling. sig/testing Categorizes an issue or PR as relevant to SIG Testing. and removed do-not-merge/needs-sig Indicates an issue or PR lacks a `sig/foo` label and requires one. labels Jun 10, 2021
@ahg-g
Copy link
Member Author

ahg-g commented Jun 10, 2021

/assign @alculquicondor @Huang-Wei

@ahg-g
Copy link
Member Author

ahg-g commented Jun 10, 2021

/cc @yuzhiquan

@fejta-bot
Copy link

This PR may require API review.

If so, when the changes are ready, complete the pre-review checklist and request an API review.

Status of requested reviews is tracked in the API Review project.

@ahg-g ahg-g changed the title Move scheduler plugin set and configuration defaulting to CC WIP: Move scheduler plugin set and configuration defaulting to CC Jun 11, 2021
@k8s-ci-robot k8s-ci-robot added the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Jun 11, 2021
@k8s-ci-robot k8s-ci-robot added the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label Jun 11, 2021
@k8s-ci-robot k8s-ci-robot removed the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label Jun 11, 2021
alculquicondor
alculquicondor reviewed Jun 11, 2021
View reviewed changes
cmd/kube-scheduler/app/options/options.go Show resolved Hide resolved
pkg/scheduler/apis/config/v1beta1/defaults.go Show resolved Hide resolved
cmd/kube-scheduler/app/server_test.go Outdated Show resolved Hide resolved
pkg/scheduler/apis/config/testing/compatibility_test.go Show resolved Hide resolved
pkg/scheduler/apis/config/v1beta1/conversion.go Outdated Show resolved Hide resolved
pkg/scheduler/apis/config/v1beta2/default_plugins.go Outdated Show resolved Hide resolved
pkg/scheduler/apis/config/v1beta1/default_plugins.go Outdated Show resolved Hide resolved
pkg/scheduler/factory.go Show resolved Hide resolved
pkg/scheduler/factory.go Outdated Show resolved Hide resolved
pkg/scheduler/framework/runtime/framework.go Show resolved Hide resolved
@ahg-g ahg-g changed the title WIP: Move scheduler plugin set and configuration defaulting to CC Move scheduler plugin set and configuration defaulting to CC Jun 12, 2021
@k8s-ci-robot k8s-ci-robot removed the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Jun 12, 2021
@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: ahg-g

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Jun 12, 2021
@ahg-g
Copy link
Member Author

ahg-g commented Jun 12, 2021

/hold
just in case someone lgtms by mistake

I fixed the integration tests in the last commit. The PR is in its final state.

@k8s-ci-robot k8s-ci-robot added the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Jun 12, 2021
@ahg-g ahg-g force-pushed the ahg-cc branch 2 times, most recently from 7358c9e to 077a63a Compare June 12, 2021 12:15
@ahg-g
Copy link
Member Author

ahg-g commented Jun 12, 2021

/retest

alculquicondor
alculquicondor reviewed Jun 14, 2021
View reviewed changes
cmd/kube-scheduler/app/server_test.go Outdated Show resolved Hide resolved
pkg/scheduler/apis/config/v1beta1/defaults.go Outdated Show resolved Hide resolved
pkg/scheduler/apis/config/v1beta1/defaults.go Outdated Show resolved Hide resolved
pkg/scheduler/apis/config/v1beta2/conversion.go Show resolved Hide resolved
pkg/scheduler/apis/config/v1beta2/defaults.go Outdated Show resolved Hide resolved
pkg/scheduler/apis/config/v1beta2/defaults.go Show resolved Hide resolved
pkg/scheduler/factory.go Outdated Show resolved Hide resolved
pkg/scheduler/apis/config/testing/config.go Outdated Show resolved Hide resolved
alculquicondor
alculquicondor reviewed Jun 16, 2021
View reviewed changes
Copy link
Member

@alculquicondor alculquicondor left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

good for squash

pkg/scheduler/apis/config/testing/defaults/defaults.go Show resolved Hide resolved
@ahg-g
Copy link
Member Author

ahg-g commented Jun 16, 2021

squashed

@alculquicondor
Copy link
Member

/lgtm

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Jun 16, 2021
@ahg-g
Copy link
Member Author

ahg-g commented Jun 16, 2021

/hold cancel

@k8s-ci-robot k8s-ci-robot removed the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Jun 16, 2021
@k8s-ci-robot k8s-ci-robot merged commit 851b727 into kubernetes:master Jun 16, 2021
@k8s-ci-robot k8s-ci-robot added this to the v1.22 milestone Jun 16, 2021
@Huang-Wei Huang-Wei mentioned this pull request Jul 20, 2021
Merged
@ahg-g ahg-g deleted the ahg-cc branch October 25, 2021 14:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@alculquicondor alculquicondor alculquicondor left review comments

@Huang-Wei Huang-Wei Huang-Wei left review comments

@yuzhiquan yuzhiquan yuzhiquan left review comments

@chendave chendave Awaiting requested review from chendave

@derekwaynecarr derekwaynecarr Awaiting requested review from derekwaynecarr

Assignees

@alculquicondor alculquicondor

@Huang-Wei Huang-Wei

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. area/test cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. kind/api-change Categorizes issue or PR as related to adding, removing, or otherwise changing an API kind/feature Categorizes issue or PR as related to a new feature. lgtm "Looks good to me", indicates that a PR is ready to be merged. needs-priority Indicates a PR lacks a `priority/foo` label and requires one. needs-triage Indicates an issue or PR lacks a `triage/foo` label and requires one. release-note-none Denotes a PR that doesn't merit a release note. sig/scheduling Categorizes an issue or PR as relevant to SIG Scheduling. sig/testing Categorizes an issue or PR as relevant to SIG Testing. size/XXL Denotes a PR that changes 1000+ lines, ignoring generated files.
Projects
None yet
Milestone
v1.22
Development

Successfully merging this pull request may close these issues.

Move scheduler plugin defaulting to ComponentConfig defaulting logic
6 participants
@ahg-g @k8s-ci-robot @fejta-bot @alculquicondor @Huang-Wei @yuzhiquan